Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8523)

Unified Diff: chrome/service/cloud_print/cloud_print_proxy.cc

Issue 2888763004: Network traffic annotation added to CloudPrintUrlFetcher. (Closed)
Patch Set: Annotations updated. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/service/cloud_print/cloud_print_proxy.cc
diff --git a/chrome/service/cloud_print/cloud_print_proxy.cc b/chrome/service/cloud_print/cloud_print_proxy.cc
index 02404069ec95d795704f0946c36523c457cd9b50..342a88cf0d95d4e34caed8a3f066b3437f4a3d78 100644
--- a/chrome/service/cloud_print/cloud_print_proxy.cc
+++ b/chrome/service/cloud_print/cloud_print_proxy.cc
@@ -228,7 +228,19 @@ void CloudPrintProxy::OnUnregisterPrinters(
ShutdownBackend();
ConnectorSettings settings;
settings.InitFrom(service_prefs_);
- wipeout_.reset(new CloudPrintWipeout(this, settings.server_url()));
+ net::PartialNetworkTrafficAnnotationTag partial_traffic_annotation =
+ net::DefinePartialNetworkTrafficAnnotation("cloud_print_proxy",
+ "cloud_print", R"(
+ semantics {
+ description:
+ "Sends a request to Cloud Print to unregister one or more "
+ "printers."
+ trigger:
+ "User request of unregistering printers or policy change."
msramek 2017/06/08 21:23:32 nit: Just to be a bit more explicit, can we say wh
Ramin Halavati 2017/06/09 04:55:46 Done, but note that the report that is generated u
+ data: "OAuth2 token and list of parinter ids to unregister."
+ })");
+ wipeout_.reset(new CloudPrintWipeout(this, settings.server_url(),
+ partial_traffic_annotation));
wipeout_->UnregisterPrinters(auth_token, printer_ids);
}

Powered by Google App Engine
This is Rietveld 408576698