Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2888733003: Update site-per-process expectations for off-main-thread-fetch virtual test suite. (Closed)

Created:
3 years, 7 months ago by alexmos
Modified:
3 years, 7 months ago
Reviewers:
Łukasz Anforowicz
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update site-per-process expectations for off-main-thread-fetch virtual test suite. https://codereview.chromium.org/2882383002 introduced this virtual test suite, breaking expectations for a couple of tests that need to be excluded for --site-per-process. BUG=477150 NOTRY=true Review-Url: https://codereview.chromium.org/2888733003 Cr-Commit-Position: refs/heads/master@{#472240} Committed: https://chromium.googlesource.com/chromium/src/+/cb60952cba2660c6cba462aed8546c1f54f35cba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/site-per-process View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
alexmos
Lukasz, can you please take a look? This takes care of 2 of the 3 ...
3 years, 7 months ago (2017-05-16 22:27:09 UTC) #3
Łukasz Anforowicz
lgtm
3 years, 7 months ago (2017-05-16 22:37:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888733003/1
3 years, 7 months ago (2017-05-16 22:50:47 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 23:08:14 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cb60952cba2660c6cba462aed854...

Powered by Google App Engine
This is Rietveld 408576698