Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h

Issue 2888673002: Add support for counting same-document AMP loads. (Closed)
Patch Set: rebase, and small updates Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h
index 5225b74c36330392bceb7d30ba5b39b4dec659af..6141c287f01ce1b58395ef102c9ad8890bc7abf0 100644
--- a/chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h
@@ -31,6 +31,9 @@ class AMPPageLoadMetricsObserver
AMP_CACHE,
GOOGLE_SEARCH_AMP_VIEWER,
GOOGLE_NEWS_AMP_VIEWER,
+
+ // New values should be added before this final entry.
+ AMP_VIEW_TYPE_LAST
};
static AMPViewType GetAMPViewType(const GURL& url);
@@ -40,6 +43,8 @@ class AMPPageLoadMetricsObserver
// page_load_metrics::PageLoadMetricsObserver:
ObservePolicy OnCommit(content::NavigationHandle* navigation_handle) override;
+ void OnCommitSameDocumentNavigation(
+ content::NavigationHandle* navigation_handle) override;
void OnDomContentLoadedEventStart(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) override;
@@ -55,6 +60,7 @@ class AMPPageLoadMetricsObserver
const page_load_metrics::PageLoadExtraInfo& info) override;
private:
+ GURL current_url_;
AMPViewType view_type_ = AMPViewType::NONE;
DISALLOW_COPY_AND_ASSIGN(AMPPageLoadMetricsObserver);

Powered by Google App Engine
This is Rietveld 408576698