Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2888623008: Remove SVGTextMetrics Width/Height getters (Closed)

Created:
3 years, 7 months ago by fs
Modified:
3 years, 7 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, fmalita+watch_chromium.org, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SVGTextMetrics Width/Height getters Remove said methods, replacing them with an additional Advance(...) overload and a new method Extents() for the users that need those (all in SVGTextQuery.) BUG=544767 Review-Url: https://codereview.chromium.org/2888623008 Cr-Commit-Position: refs/heads/master@{#472650} Committed: https://chromium.googlesource.com/chromium/src/+/53e28ff5f595446f0ed27cbc7103042c6cd76a5f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -15 lines) Patch
M third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h View 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.cpp View 2 chunks +11 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextQuery.cpp View 4 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
fs
linux_chromium_rel_ng (╯°□°)╯︵ ┻━┻
3 years, 7 months ago (2017-05-17 21:19:47 UTC) #6
pdr.
On 2017/05/17 at 21:19:47, fs wrote: > linux_chromium_rel_ng (╯°□°)╯︵ ┻━┻ LGTM linux_chromium_relly_sucks_atm
3 years, 7 months ago (2017-05-17 21:31:54 UTC) #7
pdr.
On 2017/05/17 at 21:31:54, pdr. wrote: > On 2017/05/17 at 21:19:47, fs wrote: > > ...
3 years, 7 months ago (2017-05-17 21:32:31 UTC) #8
pdr.
Btw the false rejection percentage is currently at about 30% due to ongoing infra issues.
3 years, 7 months ago (2017-05-17 21:33:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888623008/1
3 years, 7 months ago (2017-05-17 21:37:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888623008/1
3 years, 7 months ago (2017-05-17 23:09:20 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 03:48:38 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/53e28ff5f595446f0ed27cbc7103...

Powered by Google App Engine
This is Rietveld 408576698