Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2888623005: mash: Remove some WmWindow usage in ash/shelf. (Closed)

Created:
3 years, 7 months ago by msw
Modified:
3 years, 7 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Remove some WmWindow usage in ash/shelf. Just a first pass, more to come later. BUG=722551 TEST=No Chrome OS shelf changes. R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2888623005 Cr-Commit-Position: refs/heads/master@{#472245} Committed: https://chromium.googlesource.com/chromium/src/+/5d609a1b0650829208d50d74c26d4dd8dd8e9dd7

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -31 lines) Patch
M ash/shelf/shelf_layout_manager.h View 2 chunks +4 lines, -3 lines 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 13 chunks +28 lines, -26 lines 1 comment Download
M ash/shelf/wm_shelf.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
msw
Hey James, please take a look; thanks!
3 years, 7 months ago (2017-05-16 21:16:59 UTC) #2
James Cook
LGTM https://codereview.chromium.org/2888623005/diff/1/ash/shelf/shelf_layout_manager.cc File ash/shelf/shelf_layout_manager.cc (right): https://codereview.chromium.org/2888623005/diff/1/ash/shelf/shelf_layout_manager.cc#newcode238 ash/shelf/shelf_layout_manager.cc:238: aura::Window* shelf_window = shelf_widget_->GetNativeWindow(); Your patch and mine ...
3 years, 7 months ago (2017-05-16 21:50:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888623005/1
3 years, 7 months ago (2017-05-16 23:05:45 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 23:22:31 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5d609a1b0650829208d50d74c26d...

Powered by Google App Engine
This is Rietveld 408576698