Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2888623004: [WebView] Merge AwContentsClientBridgeBase into AwContentsClientBridge (Closed)

Created:
3 years, 7 months ago by Shimi Zhang
Modified:
3 years, 7 months ago
Reviewers:
boliu
CC:
chromium-reviews, cbentzel+watch_chromium.org, android-webview-reviews_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebView] Merge AwContentsClientBridgeBase into AwContentsClientBridge AwContentsClientBridgeBase was a browser/ layer interface for AwContentsClientBridge, since we can make jni calls from browser/ already, we don't need this interface anymore. This CL removes AwContentsClientBridgeBase, and put code into AwContentsClientBridge. BUG=716604 Review-Url: https://codereview.chromium.org/2888623004 Cr-Commit-Position: refs/heads/master@{#472307} Committed: https://chromium.googlesource.com/chromium/src/+/9ca8b8cd2b338ecd2dd2bcb72762fed23c811f0c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -235 lines) Patch
M android_webview/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M android_webview/browser/aw_contents.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/browser/aw_contents_client_bridge.h View 2 chunks +44 lines, -20 lines 0 comments Download
M android_webview/browser/aw_contents_client_bridge.cc View 3 chunks +58 lines, -0 lines 0 comments Download
D android_webview/browser/aw_contents_client_bridge_base.h View 1 chunk +0 lines, -107 lines 0 comments Download
D android_webview/browser/aw_contents_client_bridge_base.cc View 1 chunk +0 lines, -81 lines 0 comments Download
M android_webview/browser/aw_javascript_dialog_manager.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M android_webview/browser/net/aw_network_delegate.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc View 5 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Shimi Zhang
Bo, PTAL, thanks!
3 years, 7 months ago (2017-05-16 20:46:37 UTC) #4
boliu
lgtm
3 years, 7 months ago (2017-05-16 23:37:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888623004/1
3 years, 7 months ago (2017-05-16 23:49:29 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 03:41:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9ca8b8cd2b338ecd2dd2bcb72762...

Powered by Google App Engine
This is Rietveld 408576698