Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1132)

Unified Diff: build/toolchain/toolchain.gni

Issue 2888623003: Use a GN arg for controlling linker map file generation. (Closed)
Patch Set: agrieve comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/toolchain/gcc_toolchain.gni ('k') | tools/binary_size/diagnose_bloat.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/toolchain.gni
diff --git a/build/toolchain/toolchain.gni b/build/toolchain/toolchain.gni
index b14928d32e7869e7bfeca1ce784bca04cba17be7..8513f83fd4b331a29f19530e03cddcac02fa45ef 100644
--- a/build/toolchain/toolchain.gni
+++ b/build/toolchain/toolchain.gni
@@ -35,6 +35,19 @@ declare_args() {
# with the build. Used on iOS to ship official builds (as they are built
# with the version of clang shipped with Xcode).
use_xcode_clang = is_ios && is_official_build
+
+ # Used for binary size analysis.
+ # Currently disabled on LLD because of a bug (fixed upstream).
+ # See https://crbug.com/716209.
+ generate_linker_map = is_android && is_official_build
+}
+
+if (generate_linker_map) {
+ assert(
+ is_official_build,
+ "Linker map files should only be generated when is_official_build = true")
+ assert(target_os == "android" || target_os == "linux",
+ "Linker map files should only be generated for Android and Linux")
}
# The path to the hermetic install of Xcode. Only relevant when
« no previous file with comments | « build/toolchain/gcc_toolchain.gni ('k') | tools/binary_size/diagnose_bloat.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698