Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: build/toolchain/gcc_toolchain.gni

Issue 2888623003: Use a GN arg for controlling linker map file generation. (Closed)
Patch Set: agrieve comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/toolchain/toolchain.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/gcc_toolchain.gni
diff --git a/build/toolchain/gcc_toolchain.gni b/build/toolchain/gcc_toolchain.gni
index fa0de63052aeae948fca9aa10f020d63db87bd9b..d7286635a3d61e50b01f805e54d515422dd2df98 100644
--- a/build/toolchain/gcc_toolchain.gni
+++ b/build/toolchain/gcc_toolchain.gni
@@ -254,10 +254,8 @@ template("gcc_toolchain") {
extra_ldflags = ""
}
- # Currently disabled on LLD because of a bug (fixed upstream).
- # See https://crbug.com/716209.
enable_linker_map = defined(invoker.enable_linker_map) &&
- invoker.enable_linker_map && !use_lld
+ invoker.enable_linker_map && generate_linker_map
# These library switches can apply to all tools below.
lib_switch = "-l"
« no previous file with comments | « no previous file | build/toolchain/toolchain.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698