Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2888603005: Get SVGLayoutTreeAsText shape values from ComputedStyle (Closed)

Created:
3 years, 7 months ago by fs
Modified:
3 years, 7 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, fmalita+watch_chromium.org, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Get SVGLayoutTreeAsText shape values from ComputedStyle The values from ComputedStyle better reflect what values are actually used. Review-Url: https://codereview.chromium.org/2888603005 Cr-Commit-Position: refs/heads/master@{#473157} Committed: https://chromium.googlesource.com/chromium/src/+/e66c783498c98f236876f2c70f7688fce46eb96d

Patch Set 1 #

Patch Set 2 : Updated baselines #

Patch Set 3 : Fix baselines #

Messages

Total messages: 26 (20 generated)
fs
Another day, another trybot to fight...
3 years, 7 months ago (2017-05-18 19:08:25 UTC) #16
Stephen Chennney
lgtm
3 years, 7 months ago (2017-05-18 19:11:52 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888603005/40001
3 years, 7 months ago (2017-05-18 19:14:43 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/449401)
3 years, 7 months ago (2017-05-19 04:44:42 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888603005/40001
3 years, 7 months ago (2017-05-19 11:01:08 UTC) #23
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 11:06:57 UTC) #26
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e66c783498c98f236876f2c70f76...

Powered by Google App Engine
This is Rietveld 408576698