Replace uses of legacy SkImageGenerator API

Replace uses of legacy SkImageGenerator API

BUG=skia:6620
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2888603002
Cr-Commit-Position: refs/heads/master@{#472442}
Committed: https://chromium.googlesource.com/chromium/src/+/5e7860a0564bb5d86d6b9d98022cdadd3f190d54

[msarett, 2017-05-16 17:56:49]

Description was changed from

==========
Replace uses of legacy SkImageGenerator API

BUG=skia:6620
==========

to

==========
Replace uses of legacy SkImageGenerator API

BUG=skia:6620
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[msarett1, 2017-05-16 18:00:46]

The CQ bit was checked by msarett@chromium.org to run a CQ dry run

[msarett1, 2017-05-16 18:02:45]

msarett@chromium.org changed reviewers:
+ chcunningham@chromium.org, reveman@chromium.org

[msarett1, 2017-05-16 18:02:46]

cc/ reveman@

media/ chcunningham@

skia/ fmalita@
platform/ fmalita@

https://codereview.chromium.org/2888603002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp
(right):

https://codereview.chromium.org/2888603002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp:65:
static void doColorSpaceXform(const SkImageInfo& dst_info,
Now that readPixels() has been ramped up, we should be able to replace this
entire functions with a call to readPixels().

I'd like to look at that in a separate change.

[commit-bot: I haz the power, 2017-05-16 18:03:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2017-05-16 18:16:45]

fmalita@chromium.org changed reviewers:
+ fmalita@chromium.org

[f(malita), 2017-05-16 18:16:45]

lgtm

https://codereview.chromium.org/2888603002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp
(right):

https://codereview.chromium.org/2888603002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp:87:
alpha_type = kUnpremul_SkAlphaType;
uber-nit: i think ternary op would fit better than conditional here.

[chcunningham, 2017-05-16 18:50:54]

https://codereview.chromium.org/2888603002/diff/1/media/renderers/skcanvas_vi...
File media/renderers/skcanvas_video_renderer.cc (right):

https://codereview.chromium.org/2888603002/diff/1/media/renderers/skcanvas_vi...
media/renderers/skcanvas_video_renderer.cc:247: const Options&) override {
Should these options have implications for conversion to RGB below? Sorry,
pretty unfamiliar.

[msarett1, 2017-05-16 18:59:16]

https://codereview.chromium.org/2888603002/diff/1/media/renderers/skcanvas_vi...
File media/renderers/skcanvas_video_renderer.cc (right):

https://codereview.chromium.org/2888603002/diff/1/media/renderers/skcanvas_vi...
media/renderers/skcanvas_video_renderer.cc:247: const Options&) override {
On 2017/05/16 18:50:54, chcunningham wrote:
> Should these options have implications for conversion to RGB below? Sorry,
> pretty unfamiliar.

No problem.  The "options" should not, given that YUV is opaque and the only
current option deals with alpha blending behavior.

In theory, an SkImageGenerator should respect the width, height, color type,
color space on the SkImageInfo - but if that's something we need to do here, it
probably belongs in a separate change.  I suspect it is not necessary right now
anyway.

https://codereview.chromium.org/2888603002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp
(right):

https://codereview.chromium.org/2888603002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp:87:
alpha_type = kUnpremul_SkAlphaType;
On 2017/05/16 18:16:45, f(malita) wrote:
> uber-nit: i think ternary op would fit better than conditional here.

Done.

[msarett1, 2017-05-16 20:32:15]

The CQ bit was checked by msarett@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 20:35:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reveman, 2017-05-16 21:06:43]

cc lgtm

[chcunningham, 2017-05-16 23:55:40]

media LGTM

Thanks for the details

[commit-bot: I haz the power, 2017-05-17 04:12:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 04:12:07]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[msarett1, 2017-05-17 12:39:33]

The CQ bit was checked by msarett@chromium.org

[msarett1, 2017-05-17 12:39:33]

The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org
Link to the patchset: https://codereview.chromium.org/2888603002/#ps20001
(title: "Use ternary")

[commit-bot: I haz the power, 2017-05-17 12:39:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 13:45:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495024773050930,
"parent_rev": "3f6a8556b49a1ba7201ee1f5fac52730e87f4bf5", "commit_rev":
"5e7860a0564bb5d86d6b9d98022cdadd3f190d54"}

[commit-bot: I haz the power, 2017-05-17 13:45:46]

Description was changed from

==========
Replace uses of legacy SkImageGenerator API

BUG=skia:6620
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Replace uses of legacy SkImageGenerator API

BUG=skia:6620
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2888603002
Cr-Commit-Position: refs/heads/master@{#472442}
Committed:
https://chromium.googlesource.com/chromium/src/+/5e7860a0564bb5d86d6b9d98022c...
==========

[commit-bot: I haz the power, 2017-05-17 13:45:47]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5e7860a0564bb5d86d6b9d98022c...