Move ProxyServiceFactory to components/proxy_service/ios.

Move ProxyServiceFactory to components/proxy_service/ios.

ProxyServiceFactory does not require any code from ios/chrome and moving
it will allow for it’s reuse by ios/web_view.

BUG=none

Review-Url: https://codereview.chromium.org/2888583002
Cr-Commit-Position: refs/heads/master@{#473417}
Committed: https://chromium.googlesource.com/chromium/src/+/f74ae048d5ae528eec20a950958fbd019260229f

[michaeldo, 2017-05-16 16:06:33]

michaeldo@chromium.org changed reviewers:
+ sdefresne@chromium.org

[sdefresne, 2017-05-17 08:42:12]

sdefresne@chromium.org changed reviewers:
+ stevenjb@chromium.org

[sdefresne, 2017-05-17 08:42:12]

sdefresne@chromium.org changed required reviewers:
+ stevenjb@chromium.org

[sdefresne, 2017-05-17 08:42:13]

Code looks good to me, but I think stevenjb should review this as OWNERS and
give their approval.

One issue I have is that the factory for desktop is not in the component, and I
find it weird to have the factory for ios but not desktop. IMO, it would be
better to either move both, or none.

https://codereview.chromium.org/2888583002/diff/1/components/proxy_config/ios...
File components/proxy_config/ios/DEPS (right):

https://codereview.chromium.org/2888583002/diff/1/components/proxy_config/ios...
components/proxy_config/ios/DEPS:2: "+components/proxy_config",
Is this line required? I would expect components/foo/bar to be able to include
from components/foo. If the checkdeps pass without this line, can you remove it.
Otherwise, just leave it.

[stevenjb, 2017-05-17 16:20:05]

components/proxy_config owner lgtm

[michaeldo, 2017-05-17 17:39:43]

On 2017/05/17 08:42:13, sdefresne OOO till 22-05-2017 wrote:
> Code looks good to me, but I think stevenjb should review this as OWNERS and
> give their approval.
> 
> One issue I have is that the factory for desktop is not in the component, and
I
> find it weird to have the factory for ios but not desktop. IMO, it would be
> better to either move both, or none.
> 

The desktop version of the factory uses other parts of chrome/ so it can't be
easily moved to components. I'd still prefer to move the ios version as
otherwise I need to duplicate the exact functionality into ios/web_view. WDYT?

[michaeldo, 2017-05-18 23:21:37]

michaeldo@chromium.org changed reviewers:
+ eugenebut@chromium.org

[michaeldo, 2017-05-18 23:21:37]

+eugenebut

Would you mind taking a look at this as sdefresne is OOO?

[Eugene But (OOO till 7-30), 2017-05-18 23:58:21]

lgtm. BTW, there is still an unresolved comment from sdefresne

[michaeldo, 2017-05-19 16:46:37]

michaeldo@chromium.org changed reviewers:
+ mmenke@chromium.org

[michaeldo, 2017-05-19 16:46:37]

+ mmenke for approval of dependency on //net

[mmenke, 2017-05-19 19:35:02]

LGTM.  I guess there's no place in src/ios/ for shared code?

https://codereview.chromium.org/2888583002/diff/20001/components/proxy_config...
File components/proxy_config/ios/DEPS (right):

https://codereview.chromium.org/2888583002/diff/20001/components/proxy_config...
components/proxy_config/ios/DEPS:4: "+net"
optional:  Perhaps this should just depend on net/proxy?

[michaeldo, 2017-05-19 22:14:16]

Unfortunately there isn't a good place in ios for these types of things. But
maybe we will soon need one to share between ios/chrome and ios/web_view.

https://codereview.chromium.org/2888583002/diff/20001/components/proxy_config...
File components/proxy_config/ios/DEPS (right):

https://codereview.chromium.org/2888583002/diff/20001/components/proxy_config...
components/proxy_config/ios/DEPS:4: "+net"
On 2017/05/19 19:35:02, mmenke wrote:
> optional:  Perhaps this should just depend on net/proxy?

Done.

[michaeldo, 2017-05-19 22:14:41]

The CQ bit was checked by michaeldo@chromium.org

[michaeldo, 2017-05-19 22:14:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org, eugenebut@chromium.org, mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/2888583002/#ps40001
(title: "Update DEPS.")

[commit-bot: I haz the power, 2017-05-19 22:15:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 23:43:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 23:43:24]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[michaeldo, 2017-05-20 02:23:29]

The CQ bit was checked by michaeldo@chromium.org

[commit-bot: I haz the power, 2017-05-20 02:23:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-20 04:56:09]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495247009224820,
"parent_rev": "a11a87c830da8855d48243913a48c179457dd93d", "commit_rev":
"f74ae048d5ae528eec20a950958fbd019260229f"}

[commit-bot: I haz the power, 2017-05-20 04:56:20]

Description was changed from

==========
Move ProxyServiceFactory to components/proxy_service/ios.

ProxyServiceFactory does not require any code from ios/chrome and moving
it will allow for it’s reuse by ios/web_view.

BUG=none
==========

to

==========
Move ProxyServiceFactory to components/proxy_service/ios.

ProxyServiceFactory does not require any code from ios/chrome and moving
it will allow for it’s reuse by ios/web_view.

BUG=none

Review-Url: https://codereview.chromium.org/2888583002
Cr-Commit-Position: refs/heads/master@{#473417}
Committed:
https://chromium.googlesource.com/chromium/src/+/f74ae048d5ae528eec20a950958f...
==========

[commit-bot: I haz the power, 2017-05-20 04:56:21]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f74ae048d5ae528eec20a950958f...