Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2478)

Unified Diff: chrome/browser/ui/views/task_manager_view.cc

Issue 2888563004: Delete panel metrics and define insets in terms of distance metrics. (Closed)
Patch Set: edits 2 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/task_manager_view.cc
diff --git a/chrome/browser/ui/views/task_manager_view.cc b/chrome/browser/ui/views/task_manager_view.cc
index 00bdd99e6190edec6ef21711a886a298438afb08..cf3bb9315f79f7cda14ff11aa692f43b5e3e569b 100644
--- a/chrome/browser/ui/views/task_manager_view.cc
+++ b/chrome/browser/ui/views/task_manager_view.cc
@@ -336,10 +336,11 @@ void TaskManagerView::Init() {
AddChildView(tab_table_parent_);
SetLayoutManager(new views::FillLayout());
+ const gfx::Insets content_insets =
+ ChromeLayoutProvider::Get()->GetInsetsMetric(
+ views::INSETS_DIALOG_CONTENTS);
SetBorder(views::CreateEmptyBorder(
- ChromeLayoutProvider::Get()->GetDistanceMetric(
- DISTANCE_PANEL_CONTENT_MARGIN),
- views::kButtonHEdgeMarginNew, 0, views::kButtonHEdgeMarginNew));
+ content_insets.top(), content_insets.left(), 0, content_insets.right()));
Peter Kasting 2017/05/18 00:00:06 The 0 here looks odd. Why are we not just using t
Bret 2017/05/18 00:50:05 I guess someone wanted the "End Process" button cl
Peter Kasting 2017/05/18 00:56:28 Mrph. Can we just Do The Correct Thing all the ti
Bret 2017/05/18 01:20:30 Okay, done.
table_model_->RetrieveSavedColumnsSettingsAndUpdateTable();

Powered by Google App Engine
This is Rietveld 408576698