Delete panel metrics and define insets in terms of distance metrics.

chrome/browser/ui/views/task_manager_view.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/task_manager_view.h"
 
 #include <stddef.h>
 
 #include "build/build_config.h"
 #include "chrome/browser/browser_process.h"
@@ skipping 318 matching lines @@
   tab_table_->SetModel(table_model_.get());
   tab_table_->SetGrouper(this);
   tab_table_->set_observer(this);
   tab_table_->set_context_menu_controller(this);
   set_context_menu_controller(this);
 
   tab_table_parent_ = tab_table_->CreateParentIfNecessary();
   AddChildView(tab_table_parent_);
 
   SetLayoutManager(new views::FillLayout());
+  const gfx::Insets content_insets =
+      ChromeLayoutProvider::Get()->GetInsetsMetric(
+          views::INSETS_DIALOG_CONTENTS);
   SetBorder(views::CreateEmptyBorder(
-      ChromeLayoutProvider::Get()->GetDistanceMetric(
-          DISTANCE_PANEL_CONTENT_MARGIN),
-      views::kButtonHEdgeMarginNew, 0, views::kButtonHEdgeMarginNew));
+      content_insets.top(), content_insets.left(), 0, content_insets.right()));

[Peter Kasting, 2017/05/18 00:00:06]

The 0 here looks odd.  Why are we not just using the normal content insets?

[Bret, 2017/05/18 00:50:05]

I guess someone wanted the "End Process" button closer to the process table?
Changed it to do the correct thing in Harmony at least.

[Peter Kasting, 2017/05/18 00:56:28]

Mrph.  Can we just Do The Correct Thing all the time?  I'm OK with behavioral
changes to pre-Harmony when it seems correct and simpler.

[Bret, 2017/05/18 01:20:30]

Okay, done.

 
   table_model_->RetrieveSavedColumnsSettingsAndUpdateTable();
 
   AddAccelerator(ui::Accelerator(ui::VKEY_W, ui::EF_CONTROL_DOWN));
 }
 
 void TaskManagerView::InitAlwaysOnTopState() {
   RetrieveSavedAlwaysOnTopState();
   GetWidget()->SetAlwaysOnTop(is_always_on_top_);
 }
@@ skipping 17 matching lines @@
   if (!g_browser_process->local_state())
     return;
 
   const base::DictionaryValue* dictionary =
       g_browser_process->local_state()->GetDictionary(GetWindowName());
   if (dictionary)
     dictionary->GetBoolean("always_on_top", &is_always_on_top_);
 }
 
 }  // namespace task_manager