chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc - Issue 2888563004: Delete panel metrics and define insets in terms of distance metrics.

Unified Diff: chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc

Issue 2888563004: Delete panel metrics and define insets in terms of distance metrics. (Closed)

Patch Set: edits 2 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc ('K') | « chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc ('k') | chrome/browser/ui/views/extensions/chooser_dialog_view.cc » ('j') | chrome/browser/ui/views/extensions/extension_install_dialog_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc

diff --git a/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc b/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc

index c8784e5c9b93960e3224728c57e3e0ed1f7e8f15..555a0857011af2554873c428ceb94a4829f68718 100644

--- a/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc

+++ b/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc

@@ -45,7 +45,7 @@ DesktopIOSPromotionBubbleView::DesktopIOSPromotionBubbleView(

ChromeLayoutProvider* provider = ChromeLayoutProvider::Get();

SetBorder(views::CreateEmptyBorder(

- provider->GetDistanceMetric(DISTANCE_PANEL_CONTENT_MARGIN) +

+ provider->GetInsetsMetric(views::INSETS_BUBBLE_CONTENTS).left() +

Peter Kasting 2017/05/18 00:00:06 This looks like a dialog that rolls its own button

Bret 2017/05/18 00:50:05 This way the ultimate value doesn't change pre-har

Peter Kasting 2017/05/18 00:56:28 OK... I'd always prefer fixing stuff, even if it c

Bret 2017/05/18 01:20:30 I double-checked and it's to align the body text w

desktop_ios_promotion::GetPromoImage(

GetNativeTheme()->GetSystemColor(

ui::NativeTheme::kColorId_TextfieldDefaultColor))