Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc

Issue 2888563004: Delete panel metrics and define insets in terms of distance metrics. (Closed)
Patch Set: edits 2 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
diff --git a/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc b/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
index 4176b2a68abb08f65aae4bef6d6437f0b8282276..6c6a275434a0028f86c71a6a1bb6bbec6aa76b3e 100644
--- a/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
+++ b/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
@@ -65,11 +65,14 @@ DesktopMediaPickerDialogView::DesktopMediaPickerDialogView(
description_label_(new views::Label()),
audio_share_checkbox_(nullptr),
pane_(new views::TabbedPane()) {
+ const ChromeLayoutProvider* provider = ChromeLayoutProvider::Get();
SetLayoutManager(new views::BoxLayout(
- views::BoxLayout::kVertical, views::kButtonHEdgeMarginNew,
- ChromeLayoutProvider::Get()->GetDistanceMetric(
- DISTANCE_PANEL_CONTENT_MARGIN),
- views::kLabelToControlVerticalSpacing));
+ views::BoxLayout::kVertical,
+ provider->GetDistanceMetric(
+ views::DISTANCE_DIALOG_CONTENTS_HORIZONTAL_MARGIN),
+ provider->GetDistanceMetric(
+ views::DISTANCE_DIALOG_CONTENTS_VERTICAL_MARGIN),
+ provider->GetDistanceMetric(DISTANCE_RELATED_CONTROL_HORIZONTAL_SMALL)));
Peter Kasting 2017/05/18 00:00:06 This doesn't seem right, you've gone from a vertic
Bret 2017/05/18 00:50:05 Oops, done.
description_label_->SetMultiLine(true);
description_label_->SetHorizontalAlignment(gfx::ALIGN_LEFT);

Powered by Google App Engine
This is Rietveld 408576698