chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc - Issue 2888563004: Delete panel metrics and define insets in terms of distance metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

Issue 2888563004: Delete panel metrics and define insets in terms of distance metrics. (Closed)

Patch Set: one wrong conversion Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

index fcef94a2cd995ca50abf554a6c7b7b45910a3ca7..60f66f5b5f0091e05a547fcf154e18c9050506f1 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

@@ -216,8 +216,8 @@ void BookmarkBubbleView::Init() {

layout->AddView(title_tf_, 5, 1);

- layout->AddPaddingRow(0,

- provider->GetInsetsMetric(views::INSETS_PANEL).top());

+ layout->AddPaddingRow(

+ 0, provider->GetInsetsMetric(views::INSETS_DIALOG_CONTENTS).top());

layout->StartRow(0, cs_id);

layout->AddView(combobox_label);