Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

Issue 2888563004: Delete panel metrics and define insets in terms of distance metrics. (Closed)
Patch Set: one wrong conversion Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h" 5 #include "chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/metrics/user_metrics.h" 10 #include "base/metrics/user_metrics.h"
(...skipping 198 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 views::Label* label = new views::Label( 209 views::Label* label = new views::Label(
210 l10n_util::GetStringUTF16(IDS_BOOKMARK_BUBBLE_TITLE_TEXT)); 210 l10n_util::GetStringUTF16(IDS_BOOKMARK_BUBBLE_TITLE_TEXT));
211 layout->AddView(label); 211 layout->AddView(label);
212 title_tf_ = new views::Textfield(); 212 title_tf_ = new views::Textfield();
213 title_tf_->SetText(GetTitle()); 213 title_tf_->SetText(GetTitle());
214 title_tf_->SetAccessibleName( 214 title_tf_->SetAccessibleName(
215 l10n_util::GetStringUTF16(IDS_BOOKMARK_AX_BUBBLE_TITLE_TEXT)); 215 l10n_util::GetStringUTF16(IDS_BOOKMARK_AX_BUBBLE_TITLE_TEXT));
216 216
217 layout->AddView(title_tf_, 5, 1); 217 layout->AddView(title_tf_, 5, 1);
218 218
219 layout->AddPaddingRow(0, 219 layout->AddPaddingRow(
220 provider->GetInsetsMetric(views::INSETS_PANEL).top()); 220 0, provider->GetInsetsMetric(views::INSETS_DIALOG_CONTENTS).top());
221 221
222 layout->StartRow(0, cs_id); 222 layout->StartRow(0, cs_id);
223 layout->AddView(combobox_label); 223 layout->AddView(combobox_label);
224 layout->AddView(parent_combobox_, 5, 1); 224 layout->AddView(parent_combobox_, 5, 1);
225 225
226 layout->AddPaddingRow( 226 layout->AddPaddingRow(
227 0, provider->GetDistanceMetric(views::DISTANCE_RELATED_CONTROL_VERTICAL)); 227 0, provider->GetDistanceMetric(views::DISTANCE_RELATED_CONTROL_VERTICAL));
228 228
229 layout->StartRow(0, cs_id); 229 layout->StartRow(0, cs_id);
230 layout->SkipColumns(2); 230 layout->SkipColumns(2);
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
416 is_showing_ios_promotion_ = true; 416 is_showing_ios_promotion_ = true;
417 ios_promo_view_ = new DesktopIOSPromotionBubbleView( 417 ios_promo_view_ = new DesktopIOSPromotionBubbleView(
418 profile_, desktop_ios_promotion::PromotionEntryPoint::BOOKMARKS_BUBBLE); 418 profile_, desktop_ios_promotion::PromotionEntryPoint::BOOKMARKS_BUBBLE);
419 AddChildView(ios_promo_view_); 419 AddChildView(ios_promo_view_);
420 GetWidget()->UpdateWindowIcon(); 420 GetWidget()->UpdateWindowIcon();
421 GetWidget()->UpdateWindowTitle(); 421 GetWidget()->UpdateWindowTitle();
422 // Resize the bubble so it has the same width as the parent bubble. 422 // Resize the bubble so it has the same width as the parent bubble.
423 ios_promo_view_->UpdateBubbleHeight(); 423 ios_promo_view_->UpdateBubbleHeight();
424 } 424 }
425 #endif 425 #endif
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/arc_app_dialog_view.cc ('k') | chrome/browser/ui/views/cookie_info_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698