Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2888543003: Move skip expectations for manual tests to NeverFixTests. (Closed)

Created:
3 years, 7 months ago by qyearsley
Modified:
3 years, 7 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews, kojii, ojan
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move skip expectations for manual tests to NeverFixTests. This CL: - Moves about 80 [ Skip ] lines from TestExpectations into NeverFixTests. - Sorts the expectations lines for imported web-platform-tests. - Changes the comment at the top of NeverFixTests to suggest that the file can also be used for manual tests that we never want to run automatically. Review-Url: https://codereview.chromium.org/2888543003 Cr-Commit-Position: refs/heads/master@{#472287} Committed: https://chromium.googlesource.com/chromium/src/+/09f616277fc148aaac61828f5e76e392c33327d1

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update wording at top of NeverFixTests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+421 lines, -416 lines) Patch
M third_party/WebKit/LayoutTests/NeverFixTests View 1 4 chunks +245 lines, -159 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 17 chunks +176 lines, -257 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
qyearsley
3 years, 7 months ago (2017-05-16 17:39:18 UTC) #5
tkent
lgtm https://codereview.chromium.org/2888543003/diff/1/third_party/WebKit/LayoutTests/NeverFixTests File third_party/WebKit/LayoutTests/NeverFixTests (right): https://codereview.chromium.org/2888543003/diff/1/third_party/WebKit/LayoutTests/NeverFixTests#newcode10 third_party/WebKit/LayoutTests/NeverFixTests:10: # 7. Tests that are imported I prefer ...
3 years, 7 months ago (2017-05-16 23:25:39 UTC) #8
qyearsley
Now updated comment at the top of NeverFixTests https://codereview.chromium.org/2888543003/diff/1/third_party/WebKit/LayoutTests/NeverFixTests File third_party/WebKit/LayoutTests/NeverFixTests (right): https://codereview.chromium.org/2888543003/diff/1/third_party/WebKit/LayoutTests/NeverFixTests#newcode10 third_party/WebKit/LayoutTests/NeverFixTests:10: # ...
3 years, 7 months ago (2017-05-16 23:35:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888543003/20001
3 years, 7 months ago (2017-05-16 23:59:40 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 02:21:11 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/09f616277fc148aaac61828f5e76...

Powered by Google App Engine
This is Rietveld 408576698