Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2888533003: PPC: Work around unintended snan to qnan conversion (Closed)

Created:
3 years, 7 months ago by Sampson
Modified:
3 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Work around unintended snan to qnan conversion R=bjaideep@ca.ibm.com, jyan@ca.ibm.com, joransiu@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2888533003 Cr-Commit-Position: refs/heads/master@{#45348} Committed: https://chromium.googlesource.com/v8/v8/+/b056073000ae72156417b468bb72b7c8a43bd009

Patch Set 1 #

Patch Set 2 : Rephrase the comment to make more sense #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -25 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 1 1 chunk +21 lines, -12 lines 0 comments Download
M src/ppc/simulator-ppc.cc View 3 chunks +17 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
JaideepBajwa
lgtm
3 years, 7 months ago (2017-05-16 17:31:13 UTC) #1
john.yan
lgtm
3 years, 7 months ago (2017-05-16 17:34:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888533003/1
3 years, 7 months ago (2017-05-16 17:35:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888533003/20001
3 years, 7 months ago (2017-05-16 17:43:12 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 18:15:24 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/b056073000ae72156417b468bb72b7c8a43...

Powered by Google App Engine
This is Rietveld 408576698