Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2888503002: Mojo bindings generator: introduce Stylizer to specify naming rules. (Closed)

Created:
3 years, 7 months ago by yzshen1
Modified:
3 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo bindings generator: introduce Stylizer to specify naming rules. This CL renames the 'name' field to 'mojom_name' on various classes, and introduces Stylizer to map 'mojom_name' to 'name' which now means the stylized name. The default Stylizer just sets 'name' to the same value as 'mojom_name'. A follow-up CL will add a JavaScriptStylizer. BUG=718614 Review-Url: https://codereview.chromium.org/2888503002 Cr-Commit-Position: refs/heads/master@{#472170} Committed: https://chromium.googlesource.com/chromium/src/+/80101fbdaea7992de9cd435162351b85df4a5d40

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -202 lines) Patch
M mojo/public/tools/bindings/generators/mojom_cpp_generator.py View 1 chunk +9 lines, -9 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_java_generator.py View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/mojom_js_generator.py View 1 chunk +5 lines, -3 lines 0 comments Download
M mojo/public/tools/bindings/mojom_bindings_generator.py View 2 chunks +6 lines, -8 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/generator.py View 3 chunks +43 lines, -9 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/module.py View 15 chunks +172 lines, -77 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/translate.py View 18 chunks +63 lines, -62 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/parse/ast.py View 12 chunks +33 lines, -33 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
3 years, 7 months ago (2017-05-16 06:10:36 UTC) #4
Ken Rockot(use gerrit already)
lgtm
3 years, 7 months ago (2017-05-16 18:08:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888503002/1
3 years, 7 months ago (2017-05-16 18:15:10 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 18:29:02 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/80101fbdaea7992de9cd43516235...

Powered by Google App Engine
This is Rietveld 408576698