Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2888493002: MD Settings: About page, move copyright text in it's own card. (Closed)

Created:
3 years, 7 months ago by dpapad
Modified:
3 years, 7 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: About page, move copyright text in it's own card. BUG=716658, 716656 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2888493002 Cr-Commit-Position: refs/heads/master@{#472184} Committed: https://chromium.googlesource.com/chromium/src/+/7cf21a287bc149f34de83c2bb57b61e6d206fa6b

Patch Set 1 #

Patch Set 2 : add back unnecessary div to preserve diff for now #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -22 lines) Patch
M chrome/browser/resources/settings/about_page/about_page.html View 1 2 chunks +25 lines, -22 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
dpapad
Before/after screenshots: http://imgur.com/a/diVSq
3 years, 7 months ago (2017-05-16 17:28:45 UTC) #7
Dan Beam
lgtm
3 years, 7 months ago (2017-05-16 17:46:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888493002/20001
3 years, 7 months ago (2017-05-16 18:14:13 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 19:39:11 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7cf21a287bc149f34de83c2bb57b...

Powered by Google App Engine
This is Rietveld 408576698