Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2888463002: Refactor some first-letter handling code in TextIterator (Closed)

Created:
3 years, 7 months ago by Xiaocheng
Modified:
3 years, 7 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor some first-letter handling code in TextIterator This patch reorganizes code in TextIterator as a preparation to reduce the level of hackiness in the class. The patch consists of: 1. Introduction of helper functions to reduce code duplication 2. Delay definition of |run_start| in HandleTextBox() 3. Changing some variable types of |const unsigned| A follow-up patch will reduce the hackiness: crrev.com/2883163002 BUG=721957 TEST=n/a; no behavioral changes Review-Url: https://codereview.chromium.org/2888463002 Cr-Commit-Position: refs/heads/master@{#472031} Committed: https://chromium.googlesource.com/chromium/src/+/957d630f9df1f52475fa03759ea9451864b1a33b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -33 lines) Patch
M third_party/WebKit/Source/core/editing/iterators/TextIterator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp View 9 chunks +55 lines, -33 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 28 (23 generated)
Xiaocheng
PTAL.
3 years, 7 months ago (2017-05-16 01:57:57 UTC) #15
yosin_UTC9
lgtm BTW, for Layout NG adaptation, we have another approach, I prefer another way at ...
3 years, 7 months ago (2017-05-16 04:28:24 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888463002/1
3 years, 7 months ago (2017-05-16 04:28:43 UTC) #24
Xiaocheng
On 2017/05/16 at 04:28:24, yosin wrote: > lgtm > > BTW, for Layout NG adaptation, ...
3 years, 7 months ago (2017-05-16 06:07:57 UTC) #25
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 06:30:52 UTC) #28
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/957d630f9df1f52475fa03759ea9...

Powered by Google App Engine
This is Rietveld 408576698