Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 2888453002: DevTools: Remove contain strict from toolbars (Closed)

Created:
3 years, 7 months ago by einbinder
Modified:
3 years, 7 months ago
Reviewers:
dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Remove contain strict from toolbars Some toolbars don't take up the full width of their parent, so we can't use contain strict on them. BUG=722223, 722203 Review-Url: https://codereview.chromium.org/2888453002 Cr-Commit-Position: refs/heads/master@{#471976} Committed: https://chromium.googlesource.com/chromium/src/+/9847aeaf079339c729859157552eabde17ae3b17

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/toolbar.css View 4 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
einbinder
ptal
3 years, 7 months ago (2017-05-15 21:34:56 UTC) #2
dgozman
lgtm
3 years, 7 months ago (2017-05-15 21:55:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888453002/1
3 years, 7 months ago (2017-05-15 21:56:37 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 01:39:48 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9847aeaf079339c729859157552e...

Powered by Google App Engine
This is Rietveld 408576698