Issue 2888433004: scheduler: Put unit test code in anonymous namespace.

Issue 2888433004: scheduler: Put unit test code in anonymous namespace. (Closed)

Created:
3 years, 7 months ago by pcc1

Modified:
3 years, 7 months ago

Reviewers:
xingliu

CC:
chromium-reviews

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

scheduler: Put unit test code in anonymous namespace. This fixes an ODR violation (multiple definitions of a class named download::MockObserver), and should fix a test failure on the CFI Linux bot. https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/8068 R=xingliu@chromium.org Review-Url: https://codereview.chromium.org/2888433004 Cr-Commit-Position: refs/heads/master@{#472169} Committed: https://chromium.googlesource.com/chromium/src/+/525f68ba541ba57061c126ab7ecc4b25f3390014

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	components/download/internal/scheduler/battery_listener_unittest.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
	M	components/download/internal/scheduler/network_listener_unittest.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Total messages: 7 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888433004/1

3 years, 7 months ago (2017-05-16 17:03:12 UTC) #4

commit-bot: I haz the power

3 years, 7 months ago (2017-05-16 18:28:03 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/525f68ba541ba57061c126ab7ecc...