Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2888433002:
Roll SwiftShader 30385f0..9ed48ba (Closed)
DescriptionRoll SwiftShader 30385f0..9ed48ba
https://swiftshader.googlesource.com/SwiftShader.git/+log/30385f0..9ed48ba
- Fixes LTO causing hard crash on Linux official builds.
- Fixes buffer overflow.
BUG=720933
BUG=719291
NOTRY=true
NOPRESUBMIT=true
TBR=kbr@chromium.org
Review-Url: https://codereview.chromium.org/2888433002
Cr-Commit-Position: refs/branch-heads/3071@{#568}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed: https://chromium.googlesource.com/chromium/src/+/b01b9acf5b1e54795099cdd7a62dc07ce01f06e7
Patch Set 1 #Messages
Total messages: 21 (11 generated)
capn@chromium.org changed reviewers: + govind@chromium.org - kbr@chromium.org
PTAL. Merge approved at https://bugs.chromium.org/p/chromium/issues/detail?id=720933#c11
govind@google.com changed reviewers: + govind@google.com
lgtm
The CQ bit was checked by capn@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
On 2017/05/15 21:11:49, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. > CQ run can only be started once the patch has received an L-G-T-M from a full > committer. > Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a > full super star committer. > Committers are members of the group "project-chromium-committers". > Note that this has nothing to do with OWNERS files. LGTM
The CQ bit was checked by capn@chromium.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
Description was changed from ========== Roll SwiftShader 30385f0..9ed48ba https://swiftshader.googlesource.com/SwiftShader.git/+log/30385f0..9ed48ba - Fixes LTO causing hard crash on Linux official builds. - Fixes buffer overflow. BUG=720933 BUG=719291 TBR=kbr@chromium.org ========== to ========== Roll SwiftShader 30385f0..9ed48ba https://swiftshader.googlesource.com/SwiftShader.git/+log/30385f0..9ed48ba - Fixes LTO causing hard crash on Linux official builds. - Fixes buffer overflow. BUG=720933 BUG=719291 NOTRY=true NOPRESUBMIT=true TBR=kbr@chromium.org ==========
capn@chromium.org changed reviewers: + sugoi@chromium.org
The CQ bit was checked by capn@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494884748481550, "parent_rev":
"95b88349a8a83efee68f26b69724be640bc20c3f", "commit_rev":
"b01b9acf5b1e54795099cdd7a62dc07ce01f06e7"}
Message was sent while issue was closed.
Description was changed from ========== Roll SwiftShader 30385f0..9ed48ba https://swiftshader.googlesource.com/SwiftShader.git/+log/30385f0..9ed48ba - Fixes LTO causing hard crash on Linux official builds. - Fixes buffer overflow. BUG=720933 BUG=719291 NOTRY=true NOPRESUBMIT=true TBR=kbr@chromium.org ========== to ========== Roll SwiftShader 30385f0..9ed48ba https://swiftshader.googlesource.com/SwiftShader.git/+log/30385f0..9ed48ba - Fixes LTO causing hard crash on Linux official builds. - Fixes buffer overflow. BUG=720933 BUG=719291 NOTRY=true NOPRESUBMIT=true TBR=kbr@chromium.org Review-Url: https://codereview.chromium.org/2888433002 Cr-Commit-Position: refs/branch-heads/3071@{#568} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/b01b9acf5b1e54795099cdd7a62d... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b01b9acf5b1e54795099cdd7a62d... |
