Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 2888423002: [ObjC ARC] Converts ios/chrome/browser/ui/first_run:unit_tests to ARC. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months ago by lindsayw
Modified:
3 months, 3 weeks ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/first_run:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2888423002 Cr-Commit-Position: refs/heads/master@{#474801} Committed: https://chromium.googlesource.com/chromium/src/+/1bfe4f20d557dc2a7dd1fb27656c22d7106178b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M ios/chrome/browser/ui/first_run/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/first_run/first_run_util_unittest.mm View 2 chunks +5 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/first_run/welcome_to_chrome_view_controller_unittest.mm View 4 chunks +9 lines, -6 lines 0 comments Download
Trybot results:  mac_chromium_rel_ng   win_chromium_rel_ng   android_compile_dbg   linux_android_rel_ng   chromeos_daisy_chromium_compile_only_ng   linux_chromium_chromeos_rel_ng   linux_chromium_tsan_rel_ng   cast_shell_linux   ios-simulator   android_n5x_swarming_rel   chromium_presubmit   win_clang   ios-device   mac_chromium_compile_dbg_ng   android_clang_dbg_recipe   chromeos_amd64-generic_chromium_compile_only_ng   cast_shell_android   ios-device-xcode-clang   linux_chromium_chromeos_ozone_rel_ng   android_arm64_dbg_recipe   linux_chromium_rel_ng   win_chromium_compile_dbg_ng   ios-simulator-xcode-clang   mac_chromium_rel_ng   linux_chromium_asan_rel_ng   win_chromium_x64_rel_ng   linux_chromium_compile_dbg_ng   android_cronet   win_chromium_x64_rel_ng   chromium_presubmit   win_chromium_x64_rel_ng   win_chromium_x64_rel_ng   chromium_presubmit   win_chromium_x64_rel_ng   win_chromium_x64_rel_ng   linux_chromium_asan_rel_ng   win_clang   win_chromium_x64_rel_ng   win_chromium_rel_ng   mac_chromium_rel_ng   win_chromium_compile_dbg_ng   mac_chromium_compile_dbg_ng   ios-simulator-xcode-clang   ios-device-xcode-clang   ios-simulator   linux_chromium_compile_dbg_ng   ios-device   linux_chromium_tsan_rel_ng   linux_chromium_rel_ng   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_chromeos_rel_ng   linux_chromium_asan_rel_ng   chromeos_amd64-generic_chromium_compile_only_ng   chromeos_daisy_chromium_compile_only_ng   chromium_presubmit   linux_android_rel_ng   cast_shell_linux   android_cronet   cast_shell_android   android_n5x_swarming_rel   android_clang_dbg_recipe   android_compile_dbg   android_arm64_dbg_recipe 
Commit queue not available (can’t edit this change).

Messages

Total messages: 22 (17 generated)
lindsayw
Thanks for the review!
3 months, 4 weeks ago (2017-05-22 14:50:12 UTC) #14
lindsayw
Hi Hurt, Can you please review since Paris is out? Thank you!
3 months, 3 weeks ago (2017-05-25 14:31:31 UTC) #16
kkhorimoto
lgtm
3 months, 3 weeks ago (2017-05-25 19:08:26 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888423002/1
3 months, 3 weeks ago (2017-05-25 19:15:57 UTC) #19
commit-bot: I haz the power
3 months, 3 weeks ago (2017-05-25 21:03:55 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1bfe4f20d557dc2a7dd1fb27656c...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b