Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 2888413006: [Payment Request] Moves autofill utility function to autofill_address_util.h (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by Moe
Modified:
3 months ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, tfarina, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, rogerm+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payment Request] Moves autofill utility function to autofill_address_util.h This is in order for the payment request on iOS to use this utility function. BUG=602666 Review-Url: https://codereview.chromium.org/2888413006 Cr-Commit-Position: refs/heads/master@{#473359} Committed: https://chromium.googlesource.com/chromium/src/+/065b3d6c931cdf5a1719cac70a1896fadec77047

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment #

Messages

Total messages: 22 (13 generated)
Moe
Hi Rouslan, Please take a look.
3 months ago (2017-05-19 18:38:48 UTC) #3
please use gerrit instead
lgtm https://codereview.chromium.org/2888413006/diff/1/components/autofill/core/browser/autofill_address_util.cc File components/autofill/core/browser/autofill_address_util.cc (right): https://codereview.chromium.org/2888413006/diff/1/components/autofill/core/browser/autofill_address_util.cc#newcode64 components/autofill/core/browser/autofill_address_util.cc:64: NOTREACHED(); #include "base/logging.h"
3 months ago (2017-05-19 18:46:53 UTC) #4
Moe
Thanks. https://codereview.chromium.org/2888413006/diff/1/components/autofill/core/browser/autofill_address_util.cc File components/autofill/core/browser/autofill_address_util.cc (right): https://codereview.chromium.org/2888413006/diff/1/components/autofill/core/browser/autofill_address_util.cc#newcode64 components/autofill/core/browser/autofill_address_util.cc:64: NOTREACHED(); On 2017/05/19 18:46:53, ಠ_ಠ wrote: > #include ...
3 months ago (2017-05-19 19:09:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888413006/20001
3 months ago (2017-05-19 21:25:39 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/442911)
3 months ago (2017-05-19 21:36:59 UTC) #14
Mathieu
Lgtm
3 months ago (2017-05-19 21:49:17 UTC) #16
Moe
On 2017/05/19 21:49:17, Mathieu wrote: > Lgtm Ah Thank you Mathieu. I blame git-cl owner ...
3 months ago (2017-05-19 22:11:10 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888413006/20001
3 months ago (2017-05-19 22:12:14 UTC) #19
commit-bot: I haz the power
3 months ago (2017-05-19 22:19:15 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/065b3d6c931cdf5a1719cac70a18...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b