Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2888413004: Add KernelCodegenWorkItem stub (Closed)

Created:
3 years, 7 months ago by Johnni Winther
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add KernelCodegenWorkItem stub With this change we can run the compilation of hello_world from .dill (with --read-dill --disable-type-inference) to where we need to run the KernelSsaBuilder. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/915383a17a2616fc24c6edee717fff628de54c9e

Patch Set 1 #

Patch Set 2 : Add comment #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -20 lines) Patch
M pkg/compiler/lib/src/common/codegen.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_engine.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen_listener.dart View 1 chunk +5 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_strategy.dart View 4 chunks +30 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/source_file_provider.dart View 1 1 chunk +3 lines, -1 line 1 comment Download
M pkg/compiler/lib/src/types/types.dart View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 7 months ago (2017-05-19 14:35:57 UTC) #2
Siggi Cherem (dart-lang)
lgtm! This is exciting! https://codereview.chromium.org/2888413004/diff/20001/pkg/compiler/lib/src/source_file_provider.dart File pkg/compiler/lib/src/source_file_provider.dart (right): https://codereview.chromium.org/2888413004/diff/20001/pkg/compiler/lib/src/source_file_provider.dart#newcode211 pkg/compiler/lib/src/source_file_provider.dart:211: if (file != null && ...
3 years, 7 months ago (2017-05-19 20:09:50 UTC) #3
Johnni Winther
3 years, 7 months ago (2017-05-22 08:18:56 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
915383a17a2616fc24c6edee717fff628de54c9e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698