Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: pkg/compiler/lib/src/source_file_provider.dart

Issue 2888413004: Add KernelCodegenWorkItem stub (Closed)
Patch Set: Add comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/kernel/kernel_strategy.dart ('k') | pkg/compiler/lib/src/types/types.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/source_file_provider.dart
diff --git a/pkg/compiler/lib/src/source_file_provider.dart b/pkg/compiler/lib/src/source_file_provider.dart
index 37e3b9d55b3af1bd799c518d7ea27a73b2cf7437..3923829acda0b8173653ac5dd19fbeedb16635fc 100644
--- a/pkg/compiler/lib/src/source_file_provider.dart
+++ b/pkg/compiler/lib/src/source_file_provider.dart
@@ -206,7 +206,9 @@ class FormattingDiagnosticHandler implements CompilerDiagnostics {
print('${color(message)}');
} else {
SourceFile file = provider.sourceFiles[uri];
- if (file != null) {
+ // TODO(johnniwinther): Remove the '.dill' hack; add support for binary
+ // files to avoid crashes on trying to decode .dill binaries as utf8.
+ if (file != null && !file.filename.endsWith('.dill')) {
Siggi Cherem (dart-lang) 2017/05/19 20:09:50 eeek! but ok, I guess...
print(file.getLocationMessage(color(message), begin, end,
colorize: color));
} else {
« no previous file with comments | « pkg/compiler/lib/src/kernel/kernel_strategy.dart ('k') | pkg/compiler/lib/src/types/types.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698