Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 2888403004: [css-typed-om] replace all attribute with DOMMatrix in cssMatrixComponent (Closed)

Created:
3 years, 7 months ago by Hwanseung Lee
Modified:
3 years, 7 months ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-typed-om] replace all attribute with DOMMatrix in cssMatrixComponent replace all attribute with DOMMatrix in cssMatrixComponent. https://drafts.css-houdini.org/css-typed-om-1/#cssmatrixcomponent BUG=545318 Review-Url: https://codereview.chromium.org/2888403004 Cr-Commit-Position: refs/heads/master@{#473880} Committed: https://chromium.googlesource.com/chromium/src/+/d094fefe4ebce2a81b28a9e0b1e7d2ed553a3b75

Patch Set 1 #

Patch Set 2 : [css-typed-om] replace all attribute with DOMMatrix in cssMatrixComponent #

Patch Set 3 : [css-typed-om] replace all attribute with DOMMatrix in cssMatrixComponent #

Total comments: 2

Patch Set 4 : fix the typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -270 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/worklet/webexposed/global-interface-listing-paint-worklet-expected.txt View 1 2 1 chunk +2 lines, -22 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssMatrixComponent.html View 1 2 3 3 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssRotation.html View 3 chunks +25 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssScale.html View 1 2 chunks +14 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssSkew.html View 1 2 chunks +13 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssTransformValue.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt View 1 2 3 1 chunk +2 lines, -22 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 1 chunk +2 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.h View 2 chunks +16 lines, -104 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.cpp View 2 chunks +71 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.idl View 1 2 3 1 chunk +4 lines, -28 lines 0 comments Download

Messages

Total messages: 23 (18 generated)
Hwanseung Lee
PTAL, thank you.
3 years, 7 months ago (2017-05-20 23:02:49 UTC) #11
meade_UTC10
lgtm with nit https://codereview.chromium.org/2888403004/diff/40001/third_party/WebKit/LayoutTests/typedcssom/cssMatrixComponent.html File third_party/WebKit/LayoutTests/typedcssom/cssMatrixComponent.html (right): https://codereview.chromium.org/2888403004/diff/40001/third_party/WebKit/LayoutTests/typedcssom/cssMatrixComponent.html#newcode64 third_party/WebKit/LayoutTests/typedcssom/cssMatrixComponent.html:64: assert_throws(null, function() { new CSSMatrixComponent(undifined) }); ...
3 years, 7 months ago (2017-05-23 04:44:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888403004/60001
3 years, 7 months ago (2017-05-23 13:45:08 UTC) #19
Hwanseung Lee
https://codereview.chromium.org/2888403004/diff/40001/third_party/WebKit/LayoutTests/typedcssom/cssMatrixComponent.html File third_party/WebKit/LayoutTests/typedcssom/cssMatrixComponent.html (right): https://codereview.chromium.org/2888403004/diff/40001/third_party/WebKit/LayoutTests/typedcssom/cssMatrixComponent.html#newcode64 third_party/WebKit/LayoutTests/typedcssom/cssMatrixComponent.html:64: assert_throws(null, function() { new CSSMatrixComponent(undifined) }); On 2017/05/23 04:44:03, ...
3 years, 7 months ago (2017-05-23 13:46:27 UTC) #20
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 13:48:43 UTC) #23
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/d094fefe4ebce2a81b28a9e0b1e7...

Powered by Google App Engine
This is Rietveld 408576698