Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2888403002: Limit the number of Most Visited lines to two (Closed)

Created:
3 years, 7 months ago by gambard
Modified:
3 years, 7 months ago
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Limit the number of Most Visited lines to two The Most Visited tiles are not longer displayed on more than two lines. BUG=707754 Review-Url: https://codereview.chromium.org/2888403002 Cr-Commit-Position: refs/heads/master@{#472820} Committed: https://chromium.googlesource.com/chromium/src/+/f344e0cdffec00b918859ccc01419cd1791b35dc

Patch Set 1 #

Total comments: 14

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -0 lines) Patch
M ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm View 1 8 chunks +62 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
gambard
PTAL.
3 years, 7 months ago (2017-05-18 13:53:58 UTC) #2
Eugene But (OOO till 7-30)
lgtm Ideally you want to ask someone who understands UI code to do this review. ...
3 years, 7 months ago (2017-05-18 15:02:01 UTC) #3
gambard
Thanks! https://codereview.chromium.org/2888403002/diff/1/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm File ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm (right): https://codereview.chromium.org/2888403002/diff/1/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm#newcode105 ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm:105: const CGFloat kNumberOfMostVisitedLines = 2; On 2017/05/18 15:02:00, ...
3 years, 7 months ago (2017-05-18 15:16:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888403002/20001
3 years, 7 months ago (2017-05-18 15:16:48 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 15:28:56 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f344e0cdffec00b918859ccc0141...

Powered by Google App Engine
This is Rietveld 408576698