Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2888363003: Unbundle openh264 (Closed)

Created:
3 years, 7 months ago by Paweł Hajdan Jr.
Modified:
3 years, 7 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Unbundle openh264 This CL makes it easier for Linux distribution packagers to use system openh264 library, by providing a drop-in replacement GN file. build/linux/unbundle is a separate directory tree, so that regular Chromium developers don't need to worry about this configuration. Please see https://cs.chromium.org/chromium/src/build/linux/unbundle/README?dr for more context. BUG=551343 R=jochen@chromium.org, thestig@chromium.org Review-Url: https://codereview.chromium.org/2888363003 . Cr-Commit-Position: refs/heads/master@{#473559} Committed: https://chromium.googlesource.com/chromium/src/+/72539cb9c4fe3b6e21f1942917da60223047319d

Patch Set 1 #

Total comments: 2

Patch Set 2 : formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -6 lines) Patch
A build/linux/unbundle/openh264.gn View 1 chunk +42 lines, -0 lines 0 comments Download
M build/linux/unbundle/replace_gn_files.py View 1 chunk +1 line, -0 lines 0 comments Download
M build/shim_headers.gni View 1 1 chunk +13 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Paweł Hajdan Jr.
3 years, 7 months ago (2017-05-18 21:55:47 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/2888363003/diff/1/build/shim_headers.gni File build/shim_headers.gni (right): https://codereview.chromium.org/2888363003/diff/1/build/shim_headers.gni#newcode17 build/shim_headers.gni:17: "--generate", BTW, the indentation seems a bit off, ...
3 years, 7 months ago (2017-05-18 23:42:04 UTC) #3
jochen (gone - plz use gerrit)
lgtm
3 years, 7 months ago (2017-05-22 12:05:56 UTC) #4
Paweł Hajdan Jr.
https://codereview.chromium.org/2888363003/diff/1/build/shim_headers.gni File build/shim_headers.gni (right): https://codereview.chromium.org/2888363003/diff/1/build/shim_headers.gni#newcode17 build/shim_headers.gni:17: "--generate", On 2017/05/18 23:42:04, Lei Zhang wrote: > BTW, ...
3 years, 7 months ago (2017-05-22 12:52:26 UTC) #5
Paweł Hajdan Jr.
3 years, 7 months ago (2017-05-22 12:53:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
72539cb9c4fe3b6e21f1942917da60223047319d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698