Send certificate errors from worker fetch context for off-main-thread-fetch.

Send certificate errors from worker fetch context for off-main-thread-fetch.

BUG=443374
Review-Url: https://codereview.chromium.org/2888333002
Cr-Commit-Position: refs/heads/master@{#473096}
Committed: https://chromium.googlesource.com/chromium/src/+/c6d10d68d59de827337ca6d11e889d970e129c64

[horo, 2017-05-18 07:56:56]

Description was changed from

==========
[Not for review] Add SSLUIWorkerFetchTest

BUG=
==========

to

==========
Send certificate errors from worker fetch context for off-main-thread-fetch.

BUG=443374
==========

[horo, 2017-05-18 07:57:06]

Patchset #1 (id:1) has been deleted

[horo, 2017-05-18 07:57:11]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 07:57:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2017-05-18 08:01:02]

horo@chromium.org changed reviewers:
+ kinuko@chromium.org

[horo, 2017-05-18 08:01:02]

kinuko@
Could you please review this?

[commit-bot: I haz the power, 2017-05-18 11:19:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 11:19:28]

Dry run: This issue passed the CQ dry run.

[kinuko, 2017-05-18 14:30:21]

lgtm for what I can review

https://codereview.chromium.org/2888333002/diff/20001/chrome/browser/ssl/ssl_...
File chrome/browser/ssl/ssl_browser_tests.cc (right):

https://codereview.chromium.org/2888333002/diff/20001/chrome/browser/ssl/ssl_...
chrome/browser/ssl/ssl_browser_tests.cc:522: // substitute it into the
unsafe_importing_worker.js file.
unsafe_importing_worker -> unsafe_fetching_worker ?

https://codereview.chromium.org/2888333002/diff/20001/chrome/browser/ssl/ssl_...
chrome/browser/ssl/ssl_browser_tests.cc:2482: enum class
SSLUIWorkerFetchTestType { UseFetch, UseImportScripts };
kEnabled, kDisabled
kUseFetch, kUseImportScripts
?

[horo, 2017-05-18 14:45:18]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[horo, 2017-05-18 14:45:38]

Thank you.

https://codereview.chromium.org/2888333002/diff/20001/chrome/browser/ssl/ssl_...
File chrome/browser/ssl/ssl_browser_tests.cc (right):

https://codereview.chromium.org/2888333002/diff/20001/chrome/browser/ssl/ssl_...
chrome/browser/ssl/ssl_browser_tests.cc:522: // substitute it into the
unsafe_importing_worker.js file.
On 2017/05/18 14:30:21, kinuko wrote:
> unsafe_importing_worker -> unsafe_fetching_worker ?

Done.

https://codereview.chromium.org/2888333002/diff/20001/chrome/browser/ssl/ssl_...
chrome/browser/ssl/ssl_browser_tests.cc:2482: enum class
SSLUIWorkerFetchTestType { UseFetch, UseImportScripts };
On 2017/05/18 14:30:21, kinuko wrote:
> kEnabled, kDisabled
> kUseFetch, kUseImportScripts
> ?

Done.

[commit-bot: I haz the power, 2017-05-18 14:45:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2017-05-18 14:46:25]

horo@chromium.org changed reviewers:
+ felt@chromium.org

[horo, 2017-05-18 14:46:26]

felt@
Could you please review chrome/browser/ssl/ssl_browser_tests.cc?

[felt, 2017-05-18 16:20:56]

I don't entirely understand the background here (the bug is pretty broad in
scope). What was the existing behavior regarding certificate errors here before,
and what is the new desired behavior?

[commit-bot: I haz the power, 2017-05-18 19:00:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 19:00:43]

Dry run: This issue passed the CQ dry run.

[kinuko, 2017-05-18 20:21:41]

On 2017/05/18 16:20:56, felt wrote:
> I don't entirely understand the background here (the bug is pretty broad in
> scope). What was the existing behavior regarding certificate errors here
before,
> and what is the new desired behavior?

This is not supposed to change any behavior, but we're changing how we issue
loading requests from Web Workers in Blink in the way that we directly fetch
resources from non-main-thread, and want to make the new code work exactly same
way as we do today.  (So this patch sends the same IPC messages as what we do
today for the existing code path, e.g.
FrameHostMsg_DidRunContentWithCertificateErrors etc, but from different thread
than the main thread)

[felt, 2017-05-19 05:13:06]

OK, I follow now. lgtm.

[horo, 2017-05-19 05:21:10]

On 2017/05/19 05:13:06, felt wrote:
> OK, I follow now. lgtm.

Thank you!

[horo, 2017-05-19 05:21:11]

The CQ bit was checked by horo@chromium.org

[horo, 2017-05-19 05:21:11]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org
Link to the patchset: https://codereview.chromium.org/2888333002/#ps40001
(title: "incorporated kinuko's comment")

[commit-bot: I haz the power, 2017-05-19 05:21:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 05:27:36]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495171271231190,
"parent_rev": "b0f1618f1c3f17a71ae3eb538bb326d329869309", "commit_rev":
"c6d10d68d59de827337ca6d11e889d970e129c64"}

[commit-bot: I haz the power, 2017-05-19 05:27:46]

Description was changed from

==========
Send certificate errors from worker fetch context for off-main-thread-fetch.

BUG=443374
==========

to

==========
Send certificate errors from worker fetch context for off-main-thread-fetch.

BUG=443374

Review-Url: https://codereview.chromium.org/2888333002
Cr-Commit-Position: refs/heads/master@{#473096}
Committed:
https://chromium.googlesource.com/chromium/src/+/c6d10d68d59de827337ca6d11e88...
==========

[commit-bot: I haz the power, 2017-05-19 05:27:47]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c6d10d68d59de827337ca6d11e88...