Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2888303006: MD Settings: add missing Mac-only "tab to links" pref (Closed)

Created:
3 years, 7 months ago by Dan Beam
Modified:
3 years, 7 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, extensions-reviews_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: add missing Mac-only "tab to links" pref R=dpapad@chromium.org BUG=711680 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2888303006 Cr-Commit-Position: refs/heads/master@{#473039} Committed: https://chromium.googlesource.com/chromium/src/+/149ab23ede856cb3ee772babb840340cb5a82cf5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chrome/browser/extensions/api/settings_private/prefs_util.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/appearance_page/appearance_page.html View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Dan Beam
3 years, 7 months ago (2017-05-18 23:59:34 UTC) #2
dpapad
lgtm
3 years, 7 months ago (2017-05-19 00:16:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888303006/1
3 years, 7 months ago (2017-05-19 00:53:35 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 02:35:06 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/149ab23ede856cb3ee772babb840...

Powered by Google App Engine
This is Rietveld 408576698