Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1501)

Unified Diff: content/browser/notifications/notification_event_dispatcher_impl.h

Issue 2888303004: Minimize the delegate dependencies for non persistent notifications. (Closed)
Patch Set: review Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/notifications/notification_event_dispatcher_impl.h
diff --git a/content/browser/notifications/notification_event_dispatcher_impl.h b/content/browser/notifications/notification_event_dispatcher_impl.h
index a0b0399e470cc43f2f234cfb010f91ed9c855d38..3e19af681540d62fb5c82932df6306e1500f7508 100644
--- a/content/browser/notifications/notification_event_dispatcher_impl.h
+++ b/content/browser/notifications/notification_event_dispatcher_impl.h
@@ -5,6 +5,8 @@
#ifndef CONTENT_BROWSER_NOTIFICATIONS_NOTIFICATION_EVENT_DISPATCHER_IMPL_H_
#define CONTENT_BROWSER_NOTIFICATIONS_NOTIFICATION_EVENT_DISPATCHER_IMPL_H_
+#include <map>
+
#include "base/macros.h"
#include "base/memory/singleton.h"
#include "content/public/browser/notification_database_data.h"
@@ -34,11 +36,33 @@ class NotificationEventDispatcherImpl : public NotificationEventDispatcher {
bool by_user,
const NotificationDispatchCompleteCallback& dispatch_complete_callback)
override;
+ void DispatchNonPersistentShowEvent(
+ const std::string& notification_id) override;
+ void DispatchNonPersistentClickEvent(
+ const std::string& notification_id) override;
+ void DispatchNonPersistentCloseEvent(
+ const std::string& notification_id) override;
+
+ // Called when a renderer that had shown a non persistent notification
+ // dissappears.
+ void RendererGone(int renderer_id);
+
+ // Regsiter the fact that a non persistent notification has been
+ // displayed.
+ void RegisterNonPersistentNotification(const std::string& notification_id,
+ int renderer_id,
+ int non_persistent_id);
private:
NotificationEventDispatcherImpl();
~NotificationEventDispatcherImpl() override;
+ // Notification Id -> renderer Id.
+ std::map<std::string, int> renderer_ids_;
+
+ // Notification Id -> non-persistent notification id.
+ std::map<std::string, int> non_persistent_ids_;
+
friend struct base::DefaultSingletonTraits<NotificationEventDispatcherImpl>;
DISALLOW_COPY_AND_ASSIGN(NotificationEventDispatcherImpl);

Powered by Google App Engine
This is Rietveld 408576698