Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Side by Side Diff: content/browser/notifications/notification_event_dispatcher_impl.h

Issue 2888303004: Minimize the delegate dependencies for non persistent notifications. (Closed)
Patch Set: review Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_NOTIFICATIONS_NOTIFICATION_EVENT_DISPATCHER_IMPL_H_ 5 #ifndef CONTENT_BROWSER_NOTIFICATIONS_NOTIFICATION_EVENT_DISPATCHER_IMPL_H_
6 #define CONTENT_BROWSER_NOTIFICATIONS_NOTIFICATION_EVENT_DISPATCHER_IMPL_H_ 6 #define CONTENT_BROWSER_NOTIFICATIONS_NOTIFICATION_EVENT_DISPATCHER_IMPL_H_
7 7
8 #include <map>
9
8 #include "base/macros.h" 10 #include "base/macros.h"
9 #include "base/memory/singleton.h" 11 #include "base/memory/singleton.h"
10 #include "content/public/browser/notification_database_data.h" 12 #include "content/public/browser/notification_database_data.h"
11 #include "content/public/browser/notification_event_dispatcher.h" 13 #include "content/public/browser/notification_event_dispatcher.h"
12 14
13 namespace content { 15 namespace content {
14 16
15 class NotificationEventDispatcherImpl : public NotificationEventDispatcher { 17 class NotificationEventDispatcherImpl : public NotificationEventDispatcher {
16 public: 18 public:
17 // Returns the instance of the NotificationEventDispatcherImpl. Must be called 19 // Returns the instance of the NotificationEventDispatcherImpl. Must be called
18 // on the UI thread. 20 // on the UI thread.
19 static NotificationEventDispatcherImpl* GetInstance(); 21 static NotificationEventDispatcherImpl* GetInstance();
20 22
21 // NotificationEventDispatcher implementation. 23 // NotificationEventDispatcher implementation.
22 void DispatchNotificationClickEvent( 24 void DispatchNotificationClickEvent(
23 BrowserContext* browser_context, 25 BrowserContext* browser_context,
24 const std::string& notification_id, 26 const std::string& notification_id,
25 const GURL& origin, 27 const GURL& origin,
26 int action_index, 28 int action_index,
27 const base::NullableString16& reply, 29 const base::NullableString16& reply,
28 const NotificationDispatchCompleteCallback& dispatch_complete_callback) 30 const NotificationDispatchCompleteCallback& dispatch_complete_callback)
29 override; 31 override;
30 void DispatchNotificationCloseEvent( 32 void DispatchNotificationCloseEvent(
31 BrowserContext* browser_context, 33 BrowserContext* browser_context,
32 const std::string& notification_id, 34 const std::string& notification_id,
33 const GURL& origin, 35 const GURL& origin,
34 bool by_user, 36 bool by_user,
35 const NotificationDispatchCompleteCallback& dispatch_complete_callback) 37 const NotificationDispatchCompleteCallback& dispatch_complete_callback)
36 override; 38 override;
39 void DispatchNonPersistentShowEvent(
40 const std::string& notification_id) override;
41 void DispatchNonPersistentClickEvent(
42 const std::string& notification_id) override;
43 void DispatchNonPersistentCloseEvent(
44 const std::string& notification_id) override;
45
46 // Called when a renderer that had shown a non persistent notification
47 // dissappears.
48 void RendererGone(int renderer_id);
49
50 // Regsiter the fact that a non persistent notification has been
51 // displayed.
52 void RegisterNonPersistentNotification(const std::string& notification_id,
53 int renderer_id,
54 int non_persistent_id);
37 55
38 private: 56 private:
39 NotificationEventDispatcherImpl(); 57 NotificationEventDispatcherImpl();
40 ~NotificationEventDispatcherImpl() override; 58 ~NotificationEventDispatcherImpl() override;
41 59
60 // Notification Id -> renderer Id.
61 std::map<std::string, int> renderer_ids_;
62
63 // Notification Id -> non-persistent notification id.
64 std::map<std::string, int> non_persistent_ids_;
65
42 friend struct base::DefaultSingletonTraits<NotificationEventDispatcherImpl>; 66 friend struct base::DefaultSingletonTraits<NotificationEventDispatcherImpl>;
43 67
44 DISALLOW_COPY_AND_ASSIGN(NotificationEventDispatcherImpl); 68 DISALLOW_COPY_AND_ASSIGN(NotificationEventDispatcherImpl);
45 }; 69 };
46 70
47 } // namespace content 71 } // namespace content
48 72
49 #endif // CONTENT_BROWSER_NOTIFICATIONS_NOTIFICATION_EVENT_DISPATCHER_IMPL_H_ 73 #endif // CONTENT_BROWSER_NOTIFICATIONS_NOTIFICATION_EVENT_DISPATCHER_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698