third_party/WebKit/Source/core/css/properties/CSSPropertyShapeUtils.cpp - Issue 2888283006: CSS: Use count position values with 3 parts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/properties/CSSPropertyShapeUtils.cpp

Issue 2888283006: CSS: Use count position values with 3 parts (Closed)

Patch Set: rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp ('K') | « third_party/WebKit/Source/core/css/properties/CSSPropertyAPIScrollSnapCoordinate.cpp ('k') | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/properties/CSSPropertyShapeUtils.cpp

diff --git a/third_party/WebKit/Source/core/css/properties/CSSPropertyShapeUtils.cpp b/third_party/WebKit/Source/core/css/properties/CSSPropertyShapeUtils.cpp

index 393a62be5f36e308c2faed34b923f99236383ae9..3c3d156dc1f6eda55de5829f5a6412012d7f7963 100644

--- a/third_party/WebKit/Source/core/css/properties/CSSPropertyShapeUtils.cpp

+++ b/third_party/WebKit/Source/core/css/properties/CSSPropertyShapeUtils.cpp

@@ -34,7 +34,8 @@ static CSSBasicShapeCircleValue* ConsumeBasicShapeCircle(

if (ConsumeIdent<CSSValueAt>(args)) {

CSSValue* center_x = nullptr;

CSSValue* center_y = nullptr;

- if (!ConsumePosition(args, context.Mode(), UnitlessQuirk::kForbid, center_x,

+ if (!ConsumePosition(args, context, UnitlessQuirk::kForbid,

+ UseCounter::kThreeValuedPositionBasicShape, center_x,

center_y))

return nullptr;

shape->SetCenterX(center_x);

@@ -57,7 +58,8 @@ static CSSBasicShapeEllipseValue* ConsumeBasicShapeEllipse(