Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: third_party/WebKit/Source/core/css/properties/CSSPropertyAPIScrollSnapCoordinate.cpp

Issue 2888283006: CSS: Use count position values with 3 parts (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/properties/CSSPropertyAPIScrollSnapCoordinate.cpp
diff --git a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIScrollSnapCoordinate.cpp b/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIScrollSnapCoordinate.cpp
index 9be720bec71987ce1919d41a20ade40c1c721fce..45e93d5e3a7b2ab4698e13658e152852bc195729 100644
--- a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIScrollSnapCoordinate.cpp
+++ b/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIScrollSnapCoordinate.cpp
@@ -9,19 +9,22 @@
#include "core/css/parser/CSSParserContext.h"
#include "core/css/parser/CSSPropertyParserHelpers.h"
+// TODO(crbug.com/724912): Retire scroll-snap-coordinate
+
namespace blink {
+using namespace CSSPropertyParserHelpers;
+
static CSSValueList* ConsumePositionList(CSSParserTokenRange& range,
- CSSParserMode css_parser_mode) {
+ const CSSParserContext& context) {
CSSValueList* positions = CSSValueList::CreateCommaSeparated();
do {
- CSSValue* position =
- ConsumePosition(range, css_parser_mode,
- CSSPropertyParserHelpers::UnitlessQuirk::kForbid);
+ CSSValue* position = ConsumePosition(range, context, UnitlessQuirk::kForbid,
+ Optional<UseCounter::Feature>());
if (!position)
return nullptr;
positions->Append(*position);
- } while (CSSPropertyParserHelpers::ConsumeCommaIncludingWhitespace(range));
+ } while (ConsumeCommaIncludingWhitespace(range));
return positions;
}
@@ -30,8 +33,8 @@ const CSSValue* CSSPropertyAPIScrollSnapCoordinate::parseSingleValue(
const CSSParserContext& context,
CSSPropertyID) {
if (range.Peek().Id() == CSSValueNone)
- return CSSPropertyParserHelpers::ConsumeIdent(range);
- return ConsumePositionList(range, context.Mode());
+ return ConsumeIdent(range);
+ return ConsumePositionList(range, context);
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698