Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: chrome/browser/android/vr_shell/ui_elements/ui_element_identifiers.h

Issue 2888283005: VR: Fix HTTP warning staying visible after exiting WebVR. (Closed)
Patch Set: Remove CCT TODO and add a test for it; fix EXPECTs on booleans; cleanup. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/vr_shell/ui_elements/ui_element_identifiers.h
diff --git a/chrome/browser/android/vr_shell/ui_elements/ui_element_identifiers.h b/chrome/browser/android/vr_shell/ui_elements/ui_element_identifiers.h
new file mode 100644
index 0000000000000000000000000000000000000000..c24d39502fa9dd7bad3823a78dedb098a4c5387a
--- /dev/null
+++ b/chrome/browser/android/vr_shell/ui_elements/ui_element_identifiers.h
@@ -0,0 +1,21 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_ANDROID_VR_SHELL_UI_ELEMENTS_UI_ELEMENT_IDENTIFIERS_H_
+#define CHROME_BROWSER_ANDROID_VR_SHELL_UI_ELEMENTS_UI_ELEMENT_IDENTIFIERS_H_
+
+namespace vr_shell {
+
+// These identifiers may be used by UI elements to tag themselves for purposes
+// of testing or debugging.
+enum UiElementIdentifier {
+ kNone = 0,
+ kWebVrPermanentHttpSecurityWarning,
+ kWebVrTransientHttpSecurityWarning,
Ian Vollick 2017/05/19 14:42:32 I love the idea of exposing ID's for testing, but
cjgrant 2017/05/19 15:10:40 Continued from previous comment... As of now, tha
+ kCloseButton,
+};
+
+} // namespace vr_shell
+
+#endif // CHROME_BROWSER_ANDROID_VR_SHELL_UI_ELEMENTS_UI_ELEMENT_IDENTIFIERS_H_

Powered by Google App Engine
This is Rietveld 408576698