chrome/browser/android/vr_shell/ui_elements/ui_element_identifiers.h - Issue 2888283005: VR: Fix HTTP warning staying visible after exiting WebVR.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/android/vr_shell/ui_elements/ui_element_identifiers.h

Issue 2888283005: VR: Fix HTTP warning staying visible after exiting WebVR. (Closed)

Patch Set: Remove CCT TODO and add a test for it; fix EXPECTs on booleans; cleanup. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/android/vr_shell/ui_elements/ui_element.h ('K') | « chrome/browser/android/vr_shell/ui_elements/ui_element.h ('k') | chrome/browser/android/vr_shell/ui_scene.h » ('j') | chrome/browser/android/vr_shell/ui_scene.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_ANDROID_VR_SHELL_UI_ELEMENTS_UI_ELEMENT_IDENTIFIERS_H_

	6 #define CHROME_BROWSER_ANDROID_VR_SHELL_UI_ELEMENTS_UI_ELEMENT_IDENTIFIERS_H_

	7

	8 namespace vr_shell {

	9

	10 // These identifiers may be used by UI elements to tag themselves for purposes

	11 // of testing or debugging.

	12 enum UiElementIdentifier {

	13 kNone = 0,

	14 kWebVrPermanentHttpSecurityWarning,

	15 kWebVrTransientHttpSecurityWarning,
	Ian Vollick 2017/05/19 14:42:32 I love the idea of exposing ID's for testing, but I love the idea of exposing ID's for testing, but perhaps a UiElement could have a debug-only virtual property that returns a string? That'd keep the names closer to the classes and might be nice for output. cjgrant 2017/05/19 15:10:40 Continued from previous comment... As of now, tha Show quoted text On 2017/05/19 14:42:32, Ian Vollick wrote: > I love the idea of exposing ID's for testing, but perhaps a UiElement could have > a debug-only virtual property that returns a string? That'd keep the names > closer to the classes and might be nice for output. Continued from previous comment... As of now, that means a bunch of conditionals in the scene manager and element classes. As it is, it seems like minimal overhead, and something we could use in production if we wanted to.
	16 kCloseButton,

	17 };

	18

	19 } // namespace vr_shell

	20

	21 #endif // CHROME_BROWSER_ANDROID_VR_SHELL_UI_ELEMENTS_UI_ELEMENT_IDENTIFIERS_H_

OLD	NEW