VR: Fix HTTP warning staying visible after exiting WebVR.

chrome/browser/android/vr_shell/ui_elements/ui_element.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ANDROID_VR_SHELL_UI_ELEMENTS_UI_ELEMENT_H_
 #define CHROME_BROWSER_ANDROID_VR_SHELL_UI_ELEMENTS_UI_ELEMENT_H_
 
 #include <memory>
 #include <string>
 #include <vector>
 
 #include "base/macros.h"
+#include "chrome/browser/android/vr_shell/ui_elements/ui_element_identifiers.h"
 #include "device/vr/vr_types.h"
 
 namespace base {
 class TimeTicks;
 }
 
 namespace vr_shell {
 
 class Animation;
 class VrShellRenderer;
@@ skipping 201 matching lines @@
     return inheritable_transform_;
   }
   void set_inheritable_transform(const Transform& transform) {
     inheritable_transform_ = transform;
   }
 
   // A flag usable during transformation calculates to avoid duplicate work.
   bool dirty() const { return dirty_; }
   void set_dirty(bool dirty) { dirty_ = dirty; }
 
+  // A flag usable during transformation calculates to avoid duplicate work.
+  UiElementIdentifier identifier() const { return identifier_; }
+  void set_identifier(UiElementIdentifier identifier) {
+    identifier_ = identifier;
+  }
+
   // By default, sets an element to be visible or not. This may be overridden to
   // allow finer control of element visibility.
   virtual void SetEnabled(bool enabled);
 
  private:
   // Valid IDs are non-negative.
   int id_ = -1;
 
   // If a non-negative parent ID is specified, applicable transformations
   // are applied relative to the parent, rather than absolutely.
   int parent_id_ = -1;
 
   // If true, this object will be visible.
-  bool visible_ = true;
+  bool visible_ = false;
 
   // If false, the reticle will not hit the element, even if visible.
   bool hit_testable_ = true;
 
   // If true, transformations will be applied relative to the field of view,
   // rather than the world.
   bool lock_to_fov_ = false;
 
   // The computed lock to the FoV, incorporating lock of parent objects.
   bool computed_lock_to_fov_ = false;
@@ skipping 34 matching lines @@
   int gridline_count_ = 1;
 
   int draw_phase_ = 1;
 
   // This transform can be used by children to derive position of its parent.
   Transform inheritable_transform_;
 
   // A flag usable during transformation calculates to avoid duplicate work.
   bool dirty_ = false;
 
+  // An identifier used for testing and debugging, in lieu of a string.
+  UiElementIdentifier identifier_ = UiElementIdentifier::kNone;

[Ian Vollick, 2017/05/19 14:42:32]

If it's for debugging, could we wrap with #ifndef NDEBUG?

[cjgrant, 2017/05/19 15:10:40]

We originally wanted to use strings for this, but didn't so as to avoid the need
for NDEBUG.  If we use it, we have to wrap the getter/setter, and the scene's
GetElementByIdentifier() method, and maybe other things later (log prints about
elements, maybe).  For the tiny overhead, I'd rather just keep it in production.
 If you feel strongly though, I'll change it.

+
   Transform transform_;
 
   DISALLOW_COPY_AND_ASSIGN(UiElement);
 };
 
 }  // namespace vr_shell
 
 #endif  // CHROME_BROWSER_ANDROID_VR_SHELL_UI_ELEMENTS_UI_ELEMENT_H_