Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1243)

Issue 2888253002: Skip both paint and raster invalidation for LayoutSVGHiddenContainer subtree (Closed)

Created:
3 years, 7 months ago by Xianzhu
Modified:
3 years, 7 months ago
Reviewers:
chrishtr, fs
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Skip both paint and raster invalidation for LayoutSVGHiddenContainer subtree BUG=722761 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2888253002 Cr-Commit-Position: refs/heads/master@{#473135} Committed: https://chromium.googlesource.com/chromium/src/+/f89bf147022cf532a6f2456d5fed109301296d6f

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rebaseline-cl etc. #

Patch Set 3 : Rebaseline-cl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -1483 lines) Patch
M third_party/WebKit/LayoutTests/paint/invalidation/svg/absolute-sized-document-no-scrollbars-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/clip-path-child-changes-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/clip-path-units-changes-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/deep-dynamic-updates-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/feImage-change-target-id-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/feImage-multiple-targets-id-change-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/feImage-reference-invalidation-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/feImage-remove-target-expected.txt View 1 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/feImage-target-add-to-document-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/feImage-target-attribute-change-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/feImage-target-attribute-change-with-use-indirection-2-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/feImage-target-attribute-change-with-use-indirection-expected.txt View 1 2 chunks +0 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/feImage-target-changes-id-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/feImage-target-id-change-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/feImage-target-inline-style-change-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/feImage-target-property-change-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/feImage-target-reappend-to-document-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/feImage-target-remove-from-document-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/feImage-target-style-change-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/fecomponenttransfer-in1-change-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/filter-refresh-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/filter-width-update-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/gradient-add-stops-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/gradient-stop-style-change-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/image-with-clip-path-expected.txt View 1 2 chunks +0 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/js-late-marker-and-object-creation-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/js-late-marker-creation-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/js-late-mask-and-object-creation-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/js-late-mask-creation-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/js-update-gradient-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/js-update-pattern-child-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/js-update-pattern-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/js-update-stop-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/js-update-stop-linked-gradient-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/marker-child-changes-css-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/marker-child-changes-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/marker-viewBox-changes-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/mask-child-changes-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/mask-invalidation-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/paintorder-filtered-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/pending-resource-after-removal-expected.txt View 1 3 chunks +0 lines, -21 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/relative-sized-document-scrollbars-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/repaint-paintorder-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/resource-client-removal-expected.txt View 1 5 chunks +0 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/text-pattern-update-2-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/text-pattern-update-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/tspan-pattern-update-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/use-detach-expected.txt View 1 2 chunks +0 lines, -82 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/use-disappears-after-style-update-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/window-expected.txt View 1 1 chunk +0 lines, -36 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/js-late-gradient-and-object-creation-expected.txt View 1 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/js-late-pattern-and-object-creation-expected.txt View 1 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/tabgroup-expected.txt View 1 5 chunks +0 lines, -95 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/text-mask-update-expected.txt View 1 2 chunks +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/use-detach-expected.txt View 1 1 chunk +0 lines, -293 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/js-late-clipPath-and-object-creation-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/js-late-clipPath-creation-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/js-late-gradient-and-object-creation-expected.txt View 1 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/js-late-gradient-creation-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/js-late-pattern-and-object-creation-expected.txt View 1 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/js-late-pattern-creation-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/relative-sized-deep-shadow-tree-content-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/relative-sized-shadow-tree-content-expected.txt View 1 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/tabgroup-expected.txt View 1 5 chunks +0 lines, -95 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/text-mask-update-expected.txt View 1 2 chunks +0 lines, -25 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/use-setAttribute-crash-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/js-late-clipPath-and-object-creation-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/js-late-clipPath-creation-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/js-late-gradient-and-object-creation-expected.txt View 1 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/js-late-gradient-creation-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/js-late-pattern-and-object-creation-expected.txt View 1 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/js-late-pattern-creation-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/relative-sized-deep-shadow-tree-content-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/relative-sized-shadow-tree-content-expected.txt View 1 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/tabgroup-expected.txt View 1 5 chunks +0 lines, -95 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/text-mask-update-expected.txt View 1 2 chunks +0 lines, -25 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/use-setAttribute-crash-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/clip-path-units-changes-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/feImage-change-target-id-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/feImage-reference-invalidation-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/feImage-remove-target-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/feImage-target-add-to-document-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/feImage-target-changes-id-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/feImage-target-id-change-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/feImage-target-reappend-to-document-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/feImage-target-remove-from-document-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/fecomponenttransfer-in1-change-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/filter-width-update-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/gradient-add-stops-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/gradient-stop-style-change-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/js-update-gradient-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/js-update-stop-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/js-update-stop-linked-gradient-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/relative-sized-document-scrollbars-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/text-pattern-update-2-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/text-pattern-update-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/tspan-pattern-update-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.h View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp View 4 chunks +9 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp View 5 chunks +9 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidationTest.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.h View 1 2 chunks +17 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.cpp View 8 chunks +36 lines, -54 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (15 generated)
Xianzhu
3 years, 7 months ago (2017-05-18 03:07:01 UTC) #7
fs
lgtm https://codereview.chromium.org/2888253002/diff/1/third_party/WebKit/Source/core/paint/PaintInvalidator.h File third_party/WebKit/Source/core/paint/PaintInvalidator.h (right): https://codereview.chromium.org/2888253002/diff/1/third_party/WebKit/Source/core/paint/PaintInvalidator.h#newcode48 third_party/WebKit/Source/core/paint/PaintInvalidator.h:48: enum ForcedSubtreeInvalidationFlag { Nit: Drop the 'Forced' suffix ...
3 years, 7 months ago (2017-05-18 08:52:42 UTC) #8
fs
https://codereview.chromium.org/2888253002/diff/1/third_party/WebKit/Source/core/paint/PaintInvalidator.h File third_party/WebKit/Source/core/paint/PaintInvalidator.h (right): https://codereview.chromium.org/2888253002/diff/1/third_party/WebKit/Source/core/paint/PaintInvalidator.h#newcode48 third_party/WebKit/Source/core/paint/PaintInvalidator.h:48: enum ForcedSubtreeInvalidationFlag { On 2017/05/18 at 08:52:41, fs wrote: ...
3 years, 7 months ago (2017-05-18 08:53:29 UTC) #9
chrishtr
lgtm
3 years, 7 months ago (2017-05-18 15:27:17 UTC) #10
Xianzhu
https://codereview.chromium.org/2888253002/diff/1/third_party/WebKit/Source/core/paint/PaintInvalidator.h File third_party/WebKit/Source/core/paint/PaintInvalidator.h (right): https://codereview.chromium.org/2888253002/diff/1/third_party/WebKit/Source/core/paint/PaintInvalidator.h#newcode48 third_party/WebKit/Source/core/paint/PaintInvalidator.h:48: enum ForcedSubtreeInvalidationFlag { On 2017/05/18 08:53:29, fs wrote: > ...
3 years, 7 months ago (2017-05-18 15:42:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888253002/20001
3 years, 7 months ago (2017-05-18 15:44:18 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/448638)
3 years, 7 months ago (2017-05-18 17:34:34 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888253002/40001
3 years, 7 months ago (2017-05-19 03:36:10 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/430201)
3 years, 7 months ago (2017-05-19 05:14:44 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888253002/40001
3 years, 7 months ago (2017-05-19 05:35:33 UTC) #23
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 09:18:31 UTC) #26
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f89bf147022cf532a6f2456d5fed...

Powered by Google App Engine
This is Rietveld 408576698