Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2888203004: Properly update the payment request credit card billing combob box when a new address is added. (Closed)

Created:
3 years, 7 months ago by MAD
Modified:
3 years, 7 months ago
Reviewers:
anthonyvd
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Properly update the payment request credit card billing combob box when a new address is added. BUG=723634 Review-Url: https://codereview.chromium.org/2888203004 Cr-Commit-Position: refs/heads/master@{#472792} Committed: https://chromium.googlesource.com/chromium/src/+/efe21de9c7770038f4901f7d8fd75570a72e1747

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
MAD
It was easier than I thought. :-) BYE MAD
3 years, 7 months ago (2017-05-18 02:45:37 UTC) #4
anthonyvd
Nice, lgtm!
3 years, 7 months ago (2017-05-18 11:35:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888203004/20001
3 years, 7 months ago (2017-05-18 13:04:59 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 13:57:06 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/efe21de9c7770038f4901f7d8fd7...

Powered by Google App Engine
This is Rietveld 408576698