Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(38)

Issue 2888173003: [WebView] Remove jni_dependency_factory.h (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 1 week ago by Shimi Zhang
Modified:
5 months, 1 week ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org, agrieve+watch_chromium.org, sgurun-gerrit only
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebView] Remove jni_dependency_factory.h This CL: Removes the dependency on JniDependencyFactory due to the merging of native/ and browser/. Replaced aw_quota_manager_bridge.{h,cc} with the actual implementation aw_quota_manager_bridge_impl.{h,cc}. A few cleanup according to changes above. BUG=716604 Review-Url: https://codereview.chromium.org/2888173003 Cr-Commit-Position: refs/heads/master@{#473071} Committed: https://chromium.googlesource.com/chromium/src/+/8cfa2b45fec4dbfe7edbdc32e114669f9640578e

Patch Set 1 #

Total comments: 1

Patch Set 2 : add explicit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+436 lines, -545 lines) Patch
M android_webview/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M android_webview/browser/android_webview_jni_registrar.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/aw_browser_context.h View 3 chunks +1 line, -5 lines 0 comments Download
M android_webview/browser/aw_browser_context.cc View 3 chunks +3 lines, -7 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.h View 1 3 chunks +1 line, -4 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M android_webview/browser/aw_quota_manager_bridge.h View 1 chunk +83 lines, -6 lines 0 comments Download
M android_webview/browser/aw_quota_manager_bridge.cc View 1 chunk +326 lines, -1 line 0 comments Download
D android_webview/browser/aw_quota_manager_bridge_impl.h View 1 chunk +0 lines, -99 lines 0 comments Download
D android_webview/browser/aw_quota_manager_bridge_impl.cc View 1 chunk +0 lines, -341 lines 0 comments Download
D android_webview/browser/jni_dependency_factory.h View 1 chunk +0 lines, -33 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwQuotaManagerBridge.java View 7 chunks +15 lines, -15 lines 0 comments Download
M android_webview/lib/main/aw_main_delegate.h View 3 chunks +1 line, -9 lines 0 comments Download
M android_webview/lib/main/aw_main_delegate.cc View 3 chunks +1 line, -13 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 21 (13 generated)
Shimi Zhang
Bo, PTAL, thanks! Yet another merge CL..:P
5 months, 1 week ago (2017-05-18 00:57:48 UTC) #4
boliu
lgtm % comment https://codereview.chromium.org/2888173003/diff/1/android_webview/browser/aw_browser_context.h File android_webview/browser/aw_browser_context.h (right): https://codereview.chromium.org/2888173003/diff/1/android_webview/browser/aw_browser_context.h#newcode63 android_webview/browser/aw_browser_context.h:63: AwBrowserContext(const base::FilePath path); explicit
5 months, 1 week ago (2017-05-18 05:40:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888173003/20001
5 months, 1 week ago (2017-05-18 17:26:14 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/459072)
5 months, 1 week ago (2017-05-18 18:17:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888173003/20001
5 months, 1 week ago (2017-05-18 18:49:52 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/430982)
5 months, 1 week ago (2017-05-19 00:31:39 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888173003/20001
5 months, 1 week ago (2017-05-19 00:36:21 UTC) #18
commit-bot: I haz the power
5 months, 1 week ago (2017-05-19 03:54:40 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8cfa2b45fec4dbfe7edbdc32e114...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 81bcdb8aa