Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 2888163005: LayoutTest: Add COMPONENT to service worker and network API tests (Closed)

Created:
3 years, 7 months ago by falken
Modified:
3 years, 7 months ago
Reviewers:
shimazu, yhirano
CC:
chromium-reviews, blink-reviews, abarth-chromium
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

LayoutTest: Add COMPONENT to service worker and network API tests BUG=679905 Review-Url: https://codereview.chromium.org/2888163005 Cr-Commit-Position: refs/heads/master@{#473139} Committed: https://chromium.googlesource.com/chromium/src/+/cb5e5c8c767b33f2e50ae83050a99ef74096c98b

Patch Set 1 #

Patch Set 2 : more network api #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/fast/beacon/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/domurl/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/eventsource/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/serviceworker/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/xmlhttprequest/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/eventsource/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/chromium/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/referrer/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/thorough/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/serviceworker-proxied/thorough/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/serviceworker/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/window/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/workers/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/sendbeacon/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/streams/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/websocket/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
falken
This adds missing COMPONENT for files where the TEAM was already worker-dev or network-dev. yhirano: ...
3 years, 7 months ago (2017-05-19 01:45:39 UTC) #3
shimazu
lgtm for service worker. I double-checked by using the following commands. $ find . -name ...
3 years, 7 months ago (2017-05-19 01:57:17 UTC) #4
yhirano
lgtm
3 years, 7 months ago (2017-05-19 06:59:28 UTC) #5
falken
On 2017/05/19 01:57:17, shimazu wrote: > lgtm for service worker. > > I double-checked by ...
3 years, 7 months ago (2017-05-19 08:12:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888163005/20001
3 years, 7 months ago (2017-05-19 08:13:12 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 09:39:21 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cb5e5c8c767b33f2e50ae83050a9...

Powered by Google App Engine
This is Rietveld 408576698