Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: components/reading_list/ios/reading_list_model_bridge_observer.h

Issue 2888163004: [ObjC ARC] Converts components/reading_list/ios:ios to ARC. (Closed)
Patch Set: Adding todo for weak pointer reactoring. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/reading_list/ios/reading_list_model_bridge_observer.h
diff --git a/components/reading_list/ios/reading_list_model_bridge_observer.h b/components/reading_list/ios/reading_list_model_bridge_observer.h
index 33a433ec5b27f99f1899159dae5c116d4808925c..e3f607452755511cc4ecd04508b82aaa4505c9b3 100644
--- a/components/reading_list/ios/reading_list_model_bridge_observer.h
+++ b/components/reading_list/ios/reading_list_model_bridge_observer.h
@@ -75,6 +75,8 @@ class ReadingListModelBridge : public ReadingListModelObserver {
const GURL& url) override;
__unsafe_unretained id<ReadingListModelBridgeObserver> observer_;
+
+ // TODO(crbug.com/729015): Refactor into strong pointer
noyau (Ping after 24h) 2017/06/02 14:25:41 not into strong pointer. It could be a weak one. I
ReadingListModel* model_; // weak
DISALLOW_COPY_AND_ASSIGN(ReadingListModelBridge);
« no previous file with comments | « components/reading_list/ios/BUILD.gn ('k') | components/reading_list/ios/reading_list_model_bridge_observer.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698