Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2888163004: [ObjC ARC] Converts components/reading_list/ios:ios to ARC. (Closed)

Created:
3 years, 7 months ago by lindsayw
Modified:
3 years, 6 months ago
CC:
chromium-reviews, stkhapugin, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts components/reading_list/ios:ios to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2888163004 Cr-Commit-Position: refs/heads/master@{#476763} Committed: https://chromium.googlesource.com/chromium/src/+/f3fd628d5db7f01f9f11bf1ba00130ee03a2f2f8

Patch Set 1 #

Total comments: 5

Patch Set 2 : Adding todo for weak pointer reactoring. #

Total comments: 1

Patch Set 3 : Reworded todo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M components/reading_list/ios/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/reading_list/ios/reading_list_model_bridge_observer.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M components/reading_list/ios/reading_list_model_bridge_observer.mm View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (14 generated)
lindsayw
Thanks for the review!
3 years, 7 months ago (2017-05-18 16:29:19 UTC) #6
lindsayw
noyau@chromium.org: Please review as owner
3 years, 7 months ago (2017-05-25 14:58:13 UTC) #8
noyau (Ping after 24h)
https://codereview.chromium.org/2888163004/diff/1/components/reading_list/ios/reading_list_model_bridge_observer.mm File components/reading_list/ios/reading_list_model_bridge_observer.mm (right): https://codereview.chromium.org/2888163004/diff/1/components/reading_list/ios/reading_list_model_bridge_observer.mm#newcode17 components/reading_list/ios/reading_list_model_bridge_observer.mm:17: : observer_(observer), model_(model) { This now has the side ...
3 years, 6 months ago (2017-05-29 11:57:59 UTC) #9
stkhapugin
https://codereview.chromium.org/2888163004/diff/1/components/reading_list/ios/reading_list_model_bridge_observer.mm File components/reading_list/ios/reading_list_model_bridge_observer.mm (right): https://codereview.chromium.org/2888163004/diff/1/components/reading_list/ios/reading_list_model_bridge_observer.mm#newcode17 components/reading_list/ios/reading_list_model_bridge_observer.mm:17: : observer_(observer), model_(model) { On 2017/05/29 11:57:59, noyau (Ping ...
3 years, 6 months ago (2017-05-30 13:57:51 UTC) #10
lindsayw
https://codereview.chromium.org/2888163004/diff/1/components/reading_list/ios/reading_list_model_bridge_observer.mm File components/reading_list/ios/reading_list_model_bridge_observer.mm (right): https://codereview.chromium.org/2888163004/diff/1/components/reading_list/ios/reading_list_model_bridge_observer.mm#newcode17 components/reading_list/ios/reading_list_model_bridge_observer.mm:17: : observer_(observer), model_(model) { On 2017/05/30 13:57:51, stkhapugin wrote: ...
3 years, 6 months ago (2017-06-01 16:49:39 UTC) #11
stkhapugin
https://codereview.chromium.org/2888163004/diff/1/components/reading_list/ios/reading_list_model_bridge_observer.mm File components/reading_list/ios/reading_list_model_bridge_observer.mm (right): https://codereview.chromium.org/2888163004/diff/1/components/reading_list/ios/reading_list_model_bridge_observer.mm#newcode17 components/reading_list/ios/reading_list_model_bridge_observer.mm:17: : observer_(observer), model_(model) { On 2017/06/01 16:49:39, lindsayw wrote: ...
3 years, 6 months ago (2017-06-01 16:58:43 UTC) #12
chromium-reviews
Sorry, I thought this was an objc object. C++ object should not be naked pointers, ...
3 years, 6 months ago (2017-06-01 17:37:01 UTC) #13
lindsayw
https://codereview.chromium.org/2888163004/diff/1/components/reading_list/ios/reading_list_model_bridge_observer.mm File components/reading_list/ios/reading_list_model_bridge_observer.mm (right): https://codereview.chromium.org/2888163004/diff/1/components/reading_list/ios/reading_list_model_bridge_observer.mm#newcode17 components/reading_list/ios/reading_list_model_bridge_observer.mm:17: : observer_(observer), model_(model) { On 2017/06/01 16:58:43, stkhapugin wrote: ...
3 years, 6 months ago (2017-06-02 14:13:08 UTC) #14
noyau (Ping after 24h)
lgtm. https://codereview.chromium.org/2888163004/diff/20001/components/reading_list/ios/reading_list_model_bridge_observer.h File components/reading_list/ios/reading_list_model_bridge_observer.h (right): https://codereview.chromium.org/2888163004/diff/20001/components/reading_list/ios/reading_list_model_bridge_observer.h#newcode79 components/reading_list/ios/reading_list_model_bridge_observer.h:79: // TODO(crbug.com/729015): Refactor into strong pointer not into ...
3 years, 6 months ago (2017-06-02 14:25:41 UTC) #17
lindsayw
On 2017/06/02 14:25:41, noyau (Ping after 24h) wrote: > lgtm. > > https://codereview.chromium.org/2888163004/diff/20001/components/reading_list/ios/reading_list_model_bridge_observer.h > File ...
3 years, 6 months ago (2017-06-02 18:11:24 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888163004/40001
3 years, 6 months ago (2017-06-02 18:12:20 UTC) #23
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 19:51:49 UTC) #26
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f3fd628d5db7f01f9f11bf1ba001...

Powered by Google App Engine
This is Rietveld 408576698