chrome/browser/signin/signin_ui_util.cc - Issue 288813003: Add username of account that has an auth error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/signin_ui_util.cc

Issue 288813003: Add username of account that has an auth error. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/signin/signin_ui_util.cc

diff --git a/chrome/browser/signin/signin_ui_util.cc b/chrome/browser/signin/signin_ui_util.cc

index 884207685b1e95ed1849c8d05022f2c7388fa9e0..1dbe82774ab5798f873ed1446d3f0a47a99905d6 100644

--- a/chrome/browser/signin/signin_ui_util.cc

+++ b/chrome/browser/signin/signin_ui_util.cc

@@ -47,7 +47,7 @@ std::vector<GlobalError*> GetSignedInServiceErrors(Profile* profile) {

// errors.

SigninGlobalError* signin_error =

SigninGlobalErrorFactory::GetForProfile(profile);

- if (signin_error && signin_error->HasMenuItem())

+ if (signin_error && signin_error->HasError())

errors.push_back(signin_error);

// No auth error - now try other services. Currently the list is just hard-