Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: chrome/browser/signin/signin_global_error_unittest.cc

Issue 288813003: Add username of account that has an auth error. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/signin/signin_global_error.cc ('k') | chrome/browser/signin/signin_ui_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/signin/signin_global_error_unittest.cc
diff --git a/chrome/browser/signin/signin_global_error_unittest.cc b/chrome/browser/signin/signin_global_error_unittest.cc
index 3bd2164e1886f04c2345432f1690d64bf19a4d17..3eafc47442a47ec35365e48e137fd79ffc4ce353 100644
--- a/chrome/browser/signin/signin_global_error_unittest.cc
+++ b/chrome/browser/signin/signin_global_error_unittest.cc
@@ -23,6 +23,7 @@
#include "testing/gtest/include/gtest/gtest.h"
static const char kTestAccountId[] = "testuser@test.com";
+static const char kTestUsername[] = "testuser@test.com";
class SigninGlobalErrorTest : public testing::Test {
public:
@@ -73,8 +74,11 @@ TEST_F(SigninGlobalErrorTest, ErrorAuthStatusProvider) {
ASSERT_FALSE(global_error_->HasMenuItem());
error_provider.reset(new FakeAuthStatusProvider(error_controller_));
- error_provider->SetAuthError(kTestAccountId, GoogleServiceAuthError(
- GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS));
+ error_provider->SetAuthError(
+ kTestAccountId,
+ kTestUsername,
+ GoogleServiceAuthError(
+ GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS));
ASSERT_TRUE(global_error_->HasMenuItem());
error_provider.reset();
@@ -113,6 +117,7 @@ TEST_F(SigninGlobalErrorTest, AuthStatusEnumerateAllErrors) {
for (size_t i = 0; i < ARRAYSIZE_UNSAFE(table); ++i) {
FakeAuthStatusProvider provider(error_controller_);
provider.SetAuthError(kTestAccountId,
+ kTestUsername,
GoogleServiceAuthError(table[i].error_state));
EXPECT_EQ(global_error_->HasMenuItem(), table[i].is_error);
« no previous file with comments | « chrome/browser/signin/signin_global_error.cc ('k') | chrome/browser/signin/signin_ui_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698