Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 288813003: Add username of account that has an auth error. (Closed)

Created:
6 years, 7 months ago by Roger Tawa OOO till Jul 10th
Modified:
6 years, 7 months ago
CC:
chromium-reviews, tim+watch_chromium.org, chromium-apps-reviews_chromium.org, maniscalco+watch_chromium.org, haitaol+watch_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Add username of account that has an auth error. This is general cleanup to help move to gaia obfuscated as the account id. The CL just changes the interface for now. It will be used in reporting auth errors in the avatar button, see CL https://codereview.chromium.org/284033002/ for details. BUG=311235 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270847

Patch Set 1 #

Patch Set 2 : Fix mac build error #

Patch Set 3 : rebased #

Patch Set 4 : rebased #

Total comments: 6

Patch Set 5 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -15 lines) Patch
M chrome/browser/extensions/api/identity/account_tracker.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/identity/account_tracker.cc View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/identity/identity_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/signin/fake_signin_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/signin/signin_error_notifier_ash_unittest.cc View 1 2 3 6 chunks +13 lines, -4 lines 0 comments Download
M chrome/browser/signin/signin_global_error.h View 3 chunks +13 lines, -1 line 0 comments Download
M chrome/browser/signin/signin_global_error.cc View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/signin/signin_global_error_unittest.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/signin/signin_ui_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_ui_util_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_unittest.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/signin/core/browser/fake_auth_status_provider.h View 2 chunks +3 lines, -0 lines 0 comments Download
M components/signin/core/browser/fake_auth_status_provider.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M components/signin/core/browser/mutable_profile_oauth2_token_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/signin/core/browser/mutable_profile_oauth2_token_service.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M components/signin/core/browser/signin_error_controller.h View 3 chunks +5 lines, -0 lines 0 comments Download
M components/signin/core/browser/signin_error_controller.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M components/signin/core/browser/signin_error_controller_unittest.cc View 9 chunks +20 lines, -3 lines 0 comments Download
M components/signin/ios/browser/profile_oauth2_token_service_ios.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/signin/ios/browser/profile_oauth2_token_service_ios.mm View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Roger Tawa OOO till Jul 10th
Hi Michael, Alexei, Nicolas, Michael: can you please take a look? Nicloas: can you look ...
6 years, 7 months ago (2014-05-15 02:26:26 UTC) #1
Alexei Svitkine (slow)
cocoa/ lgtm, I didn't look at the other files
6 years, 7 months ago (2014-05-15 15:27:24 UTC) #2
Michael Courage
lgtm https://codereview.chromium.org/288813003/diff/60001/chrome/browser/extensions/api/identity/account_tracker.cc File chrome/browser/extensions/api/identity/account_tracker.cc (right): https://codereview.chromium.org/288813003/diff/60001/chrome/browser/extensions/api/identity/account_tracker.cc#newcode251 chrome/browser/extensions/api/identity/account_tracker.cc:251: if (account_errors_.size() > 0) { Might be clearer ...
6 years, 7 months ago (2014-05-15 17:18:54 UTC) #3
Roger Tawa OOO till Jul 10th
Thanks Michael. Comments addressed, changes uploaded. https://codereview.chromium.org/288813003/diff/60001/chrome/browser/extensions/api/identity/account_tracker.cc File chrome/browser/extensions/api/identity/account_tracker.cc (right): https://codereview.chromium.org/288813003/diff/60001/chrome/browser/extensions/api/identity/account_tracker.cc#newcode251 chrome/browser/extensions/api/identity/account_tracker.cc:251: if (account_errors_.size() > ...
6 years, 7 months ago (2014-05-15 18:24:08 UTC) #4
Nicolas Zea
sync LGTM (feel free to TBR for callsite changes like that)
6 years, 7 months ago (2014-05-15 18:24:58 UTC) #5
Roger Tawa OOO till Jul 10th
The CQ bit was checked by rogerta@chromium.org
6 years, 7 months ago (2014-05-15 18:27:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/288813003/80001
6 years, 7 months ago (2014-05-15 18:28:00 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-15 21:31:14 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 23:23:41 UTC) #9
Message was sent while issue was closed. 
Change committed as 270847

Powered by Google App Engine
This is Rietveld 408576698